[ui] Edge: Remove edge visiblity because not used right now

Author: nicolas-lambert-tc

meshroom/core/graph.py

@@ -61,12 +61,11 @@ def GraphModification(graph):
 
 class Edge(BaseObject):
 
-    def __init__(self, src, dst, parent=None, visible=True):
+    def __init__(self, src, dst, parent=None):
         super().__init__(parent)
         self._src = weakref.ref(src)
         self._dst = weakref.ref(dst)
         self._repr = f"<Edge> {self._src()} -> {self._dst()}"
-        self._visible = visible
 
     @property
     def src(self):
@@ -75,17 +74,9 @@ def src(self):
     @property
     def dst(self):
         return self._dst()
-    
-    def setVisible(self, visible: bool):
-        self._visible = visible
-    
-    def getVisible(self) -> bool:
-        return self._visible
 
     src = Property(Attribute, src.fget, constant=True)
     dst = Property(Attribute, dst.fget, constant=True)
-    isVisibleChanged = Signal()
-    isVisible = Property(bool, getVisible, setVisible, notify=isVisibleChanged)
 
 
 WHITE = 0
@@ -218,7 +209,6 @@ def __init__(self, name: str = "", parent: BaseObject = None):
         self._nodes = DictModel(keyAttrName='name', parent=self)
         # Edges: use dst attribute as unique key since it can only have one input connection
         self._edges = DictModel(keyAttrName='dst', parent=self)
-        self._visiblEdges = DictModel(keyAttrName="dstAttr", parent=self)
         self._compatibilityNodes = DictModel(keyAttrName='name', parent=self)
         self._cacheDir: str = ''
         self._filepath: str = ''
@@ -902,7 +892,7 @@ def getRootNodes(self, dependenciesOnly):
         return set(self._nodes) - nodesWithInputLink
 
     @changeTopology
-    def addEdge(self, srcAttr, dstAttr, visible=True):
+    def addEdge(self, srcAttr, dstAttr):
 
         assert isinstance(srcAttr, Attribute)
         assert isinstance(dstAttr, Attribute)
@@ -914,7 +904,7 @@ def addEdge(self, srcAttr, dstAttr, visible=True):
         if not dstAttr.isCompatibleWith(srcAttr):
             raise AttributeCompatibilityError(f'Attribute: "{srcAttr.name}" can not be connected to "{dstAttr.name}" because they are not compatible')
 
-        edge = Edge(srcAttr, dstAttr, visible=visible)
+        edge = Edge(srcAttr, dstAttr)
         self.edges.add(edge)
         self.markNodesDirty(dstAttr.node)
         dstAttr.valueChanged.emit()
@@ -1597,13 +1587,6 @@ def setVerbose(self, v):
                     except Exception:
                         pass
 
-    def getVisibleEdges(self):        
-        self._visiblEdges.clear()
-        for e in self.edges:
-            if e.getVisible():
-                self._visiblEdges.add(e)
-        return self._visiblEdges
-
     nodes = Property(BaseObject, nodes.fget, constant=True)
     edges = Property(BaseObject, edges.fget, constant=True)
     filepathChanged = Signal()
@@ -1617,8 +1600,6 @@ def getVisibleEdges(self):
     updated = Signal()
     canComputeLeavesChanged = Signal()
     canComputeLeaves = Property(bool, lambda self: self._canComputeLeaves, notify=canComputeLeavesChanged)
-    visibleEdges = Property(BaseObject, getVisibleEdges, notify=updated)
-
 
 def loadGraph(filepath, strictCompatibility: bool = False) -> Graph:
     """

meshroom/ui/qml/GraphEditor/GraphEditor.qml

@@ -476,13 +476,13 @@ Item {
                 id: edgesRepeater
 
                 // Delay edges loading after nodes (edges needs attribute pins to be created)
-                model: nodeRepeater.loaded && root.graph ? root.graph.visibleEdges : undefined
+                model: nodeRepeater.loaded && root.graph ? root.graph.edges : undefined
 
                 delegate: Edge {
                     property var src: recursivelyRetrieveAttributePin(edge.src)
                     property var dst: recursivelyRetrieveAttributePin(edge.dst)
                     property bool isValidEdge: src !== undefined && dst !== undefined
-                    visible: isValidEdge && src && dst && src.visible && dst.visible
+                    visible: isValidEdge && src && dst
 
                     property bool forLoop: src.attribute.type === "ListAttribute" && dst.attribute.type != "ListAttribute"