[core] add trace log level and add new "loglevel" internal input for node default log level

Author: Alxiice

bin/meshroom_batch

@@ -8,7 +8,7 @@ import re
 import sys
 
 import meshroom.core.graph
-from meshroom import setupEnvironment
+from meshroom import setupEnvironment, logStringToPython
 
 setupEnvironment()
 
@@ -135,14 +135,6 @@ advanced_group.add_argument(
 
 args = parser.parse_args()
 
-logStringToPython = {
-    'fatal': logging.FATAL,
-    'error': logging.ERROR,
-    'warning': logging.WARNING,
-    'info': logging.INFO,
-    'debug': logging.DEBUG,
-    'trace': logging.DEBUG,
-}
 logging.getLogger().setLevel(logStringToPython[args.verbose])
 
 if not args.input and not args.inputRecursive:

meshroom/__init__.py

@@ -48,13 +48,32 @@ class VersionStatus(Enum):
 
 useMultiChunks = util.strtobool(os.environ.get("MESHROOM_USE_MULTI_CHUNKS", "True"))
 
+# Logging
+
+def addTraceLevel():
+    """ From https://stackoverflow.com/a/35804945 """
+    levelName, methodName, levelNum = 'TRACE', 'trace', logging.DEBUG - 5
+    if hasattr(logging, levelName) or hasattr(logging, methodName)or hasattr(logging.getLoggerClass(), methodName):
+       return
+    def logForLevel(self, message, *args, **kwargs):
+        if self.isEnabledFor(levelNum):
+            self._log(levelNum, message, args, **kwargs)
+    def logToRoot(message, *args, **kwargs):
+        logging.log(levelNum, message, *args, **kwargs)
+
+    logging.addLevelName(levelNum, levelName)
+    setattr(logging, levelName, levelNum)
+    setattr(logging.getLoggerClass(), methodName, logForLevel)
+    setattr(logging, methodName, logToRoot)
+
+addTraceLevel()
 logStringToPython = {
-    'fatal': logging.FATAL,
+    'fatal': logging.CRITICAL,
     'error': logging.ERROR,
     'warning': logging.WARNING,
     'info': logging.INFO,
     'debug': logging.DEBUG,
-    'trace': logging.DEBUG,
+    'trace': logging.TRACE,
 }
 logging.getLogger().setLevel(logStringToPython[os.environ.get('MESHROOM_VERBOSE', 'warning')])
 

meshroom/core/desc/node.py

@@ -9,7 +9,7 @@
 import sys
 
 from .computation import Level, StaticNodeSize
-from .attribute import StringParam, ColorParam
+from .attribute import StringParam, ColorParam, ChoiceParam
 
 import meshroom
 from meshroom.core import cgroup
@@ -67,6 +67,14 @@ class BaseNode(object):
             value="",
             invalidate=False,
         ),
+        ChoiceParam(
+            name='nodeDefaultLogLevel',
+            label='Default logging level',
+            description='''Default logging level for the node (critical, error, warning, info, debug).''',
+            value='info',
+            values=['critical', 'error', 'warning', 'info', 'debug', 'trace'],
+            invalidate=False,
+        ),
         ColorParam(
             name="color",
             label="Color",

meshroom/core/node.py

@@ -310,7 +310,8 @@ def completeProgressBar(self):
 
     @staticmethod
     def textToLevel(text):
-        if text == "critical":
+        text = text.lower()
+        if text in ["critical", "fatal"]:
             return logging.CRITICAL
         elif text == "error":
             return logging.ERROR
@@ -320,6 +321,8 @@ def textToLevel(text):
             return logging.INFO
         elif text == "debug":
             return logging.DEBUG
+        elif text == "trace":
+            return logging.TRACE
         else:
             return logging.NOTSET
 
@@ -726,6 +729,15 @@ def getLabel(self):
                 return label
         return self.getDefaultLabel()
 
+    def getNodeLogLevel(self):
+        """
+        Returns:
+            str: the user-provided log level used for logging on process launched by this node
+        """
+        if self.hasInternalAttribute("nodeDefaultLogLevel"):
+            return self.internalAttribute("nodeDefaultLogLevel").value.strip()
+        return "info"
+    
     def getColor(self):
         """
         Returns:
@@ -1346,8 +1358,7 @@ def prepareLogger(self, iteration=-1):
         # Setup logger
         rootLogger = logging.getLogger()
         self._logManager = LogManager(rootLogger, logFile)
-        self._logManager.configureLogger()
-        rootLogger.setLevel(logging.INFO)  # Set info by default
+        self._logManager.start(self.getNodeLogLevel())
 
     def restoreLogger(self):
         self._logManager.restorePreviousLogger()

meshroom/core/nodeFactory.py

@@ -174,13 +174,15 @@ def _checkAttributesCompatibility(
 
     def _createNode(self) -> Node:
         logging.info(f"Creating node '{self.name}'")
-        # TODO: user inputs/outputs may conflicts with internal names (like position, uid)
+        # TODO: user inputs/outputs may conflicts with internal names (like logLevel, position, uid)
+        # The line below can cause UI issues but at least prevent crashes
+        internalInputs = {k: v for k, v in self.internalInputs.items() if k not in self.inputs.keys()}
         return Node(
             self.nodeType,
             position=self.position,
             uid=self.uid,
             **self.inputs,
-            **self.internalInputs,
+            **internalInputs,
             **self.outputs,
         )