Skip to content

Commit 648b095

Browse files
authored
Merge pull request #2606 from alicevision/fix/uiFixes
[ui] Minor UI stabilization fixes for Qt 6
2 parents b5dda4e + fdcf35c commit 648b095

File tree

8 files changed

+34
-18
lines changed

8 files changed

+34
-18
lines changed

meshroom/ui/qml/Controls/ExpandableGroup.qml

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -22,21 +22,24 @@ GroupBox {
2222
topPadding: label.height + padding
2323
background: Item {}
2424

25+
MouseArea {
26+
parent: paneLabel
27+
anchors.fill: parent
28+
onClicked: function(mouse) {
29+
expandButton.checked = !expandButton.checked
30+
}
31+
}
32+
2533
label: Pane {
34+
id: paneLabel
35+
padding: 2
36+
width: root.width
37+
2638
background: Rectangle {
2739
id: labelBg
2840
color: palette.base
2941
opacity: 0.8
30-
31-
MouseArea {
32-
anchors.fill: parent
33-
onClicked: {
34-
expandButton.checked = !expandButton.checked
35-
}
36-
}
3742
}
38-
padding: 2
39-
width: root.width
4043

4144
RowLayout {
4245
width: parent.width

meshroom/ui/qml/GraphEditor/Edge.qml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ Item {
120120
iconText: MaterialIcons.loop
121121
label: (root.iteration + 1) + "/" + root.loopSize + " "
122122

123-
color: palette.base
123+
labelIconColor: palette.base
124124
ToolTip.text: "Foreach Loop"
125125
}
126126

meshroom/ui/qml/Homepage.qml

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -239,10 +239,15 @@ Page {
239239
}
240240

241241
MaterialToolLabelButton {
242+
Layout.topMargin: 10
242243
Layout.bottomMargin: 10
243-
Layout.fillWidth: true
244-
labelItem.horizontalAlignment: Text.AlignHCenter
245-
label: MaterialIcons.favorite + " Support AliceVision"
244+
Layout.alignment: Qt.AlignHCenter
245+
label: "Support AliceVision"
246+
iconText: MaterialIcons.favorite
247+
248+
// Slightly "extend" the clickable area for the button while preserving the centered layout
249+
iconItem.leftPadding: 15
250+
labelItem.rightPadding: 15
246251

247252
onClicked: Qt.openUrlExternally("https://alicevision.org/association/#donate")
248253
}
@@ -347,6 +352,7 @@ Page {
347352
ToolTip.visible: hovered
348353
ToolTip.text: modelData["path"] ? modelData["path"] : "Open browser to select a project file"
349354

355+
font.family: MaterialIcons.fontFamily
350356
font.pointSize: 24
351357

352358
text: modelData["path"] ? (modelData["thumbnail"] ? "" : MaterialIcons.description) : MaterialIcons.folder_open

meshroom/ui/qml/MaterialIcons/MaterialToolLabel.qml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ Item {
1212
property alias iconText: iconItem.text
1313
property alias iconSize: iconItem.font.pointSize
1414
property alias label: labelItem.text
15-
property var color: palette.text
15+
property var labelIconColor: palette.text
1616
implicitWidth: childrenRect.width
1717
implicitHeight: childrenRect.height
1818
anchors.rightMargin: 5
@@ -24,12 +24,12 @@ Item {
2424
font.pointSize: 13
2525
padding: 0
2626
text: ""
27-
color: color
27+
color: labelIconColor
2828
}
2929
Label {
3030
id: labelItem
3131
text: ""
32-
color: color
32+
color: labelIconColor
3333
}
3434
}
3535

meshroom/ui/qml/Viewer/SfmGlobalStats.qml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ import QtQuick.Layouts
55

66
import AliceVision 1.0 as AliceVision
77
import Charts 1.0
8+
import Controls 1.0
9+
import Utils 1.0
810

911
FloatingPane {
1012
id: root

meshroom/ui/qml/Viewer/SfmStatsView.qml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ import QtQuick.Layouts
55

66
import AliceVision 1.0 as AliceVision
77
import Charts 1.0
8+
import Controls 1.0
9+
import Utils 1.0
810

911

1012
FloatingPane {

meshroom/ui/qml/Viewer3D/Inspector3D.qml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import QtQuick
22
import QtQuick.Controls
3-
import QtQuick.Controls.Material 2.12
43
import QtQuick.Layouts
54
import Qt3D.Core 2.6
65
import Qt3D.Render 2.6
@@ -229,6 +228,7 @@ FloatingPane {
229228

230229
Label {
231230
text: resectionIdSlider.value + "/" + Viewer3DSettings.resectionIdCount
231+
color: palette.text
232232
visible: Viewer3DSettings.displayResectionIds
233233
}
234234
}
@@ -252,6 +252,7 @@ FloatingPane {
252252
return 0
253253

254254
}
255+
labelIconColor: palette.text
255256
ToolTip.text: "Number Of Cameras In Current Resection Group"
256257
visible: Viewer3DSettings.displayResectionIds
257258
}
@@ -269,6 +270,7 @@ FloatingPane {
269270

270271
return currentCameras
271272
}
273+
labelIconColor: palette.text
272274
ToolTip.text: "Number Of Cumulated Cameras"
273275
visible: Viewer3DSettings.displayResectionIds
274276
}
@@ -285,6 +287,7 @@ FloatingPane {
285287

286288
return totalCameras
287289
}
290+
labelIconColor: palette.text
288291
ToolTip.text: "Total Number Of Cameras"
289292
visible: Viewer3DSettings.displayResectionIds
290293
}

meshroom/ui/qml/WorkspaceView.qml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,7 @@ Item {
258258
Inspector3D {
259259
id: inspector3d
260260
SplitView.preferredWidth: 220
261-
SplitView.minimumWidth: 10
261+
SplitView.minimumWidth: 100
262262

263263
mediaLibrary: c_viewer3D.library
264264
camera: c_viewer3D.mainCamera

0 commit comments

Comments
 (0)