[ui] Node: When an attribute valuechange node check for attribute validity. Id one is not valid an icon is added

Author: nicolas-lambert-tc

meshroom/common/PySignal.py

@@ -158,6 +158,10 @@ class ClassSignal:
     """
     _map = {}
 
+    def __init__(self, *args, **kwargs):
+        self._args = args
+        self._kwargs = kwargs
+
     def __get__(self, instance, owner):
         if instance is None:
             # When we access ClassSignal element on the class object without any instance,

meshroom/ui/qml/Application.qml

@@ -268,7 +268,15 @@ Page {
                 unsavedSubmitDialog.open()
             } else {
                 try {
-                    _reconstruction.submit(nodes)
+
+                    if ( nodes.find(node => node.hasInvalidAttribute) ) {
+                        submitWithWarningDialog.nodes = nodes
+                        submitWithWarningDialog.open()
+                    } else {
+                        submit.open()
+                        //_reconstruction.submit(nodes)
+                    }
+
                 }
                 catch (error) {
                     const data = ErrorHandler.analyseError(error)
@@ -399,6 +407,26 @@ Page {
             onAccepted: saveAsAction.trigger()
         }
 
+        MessageDialog {
+            id: submitWithWarningDialog
+
+            canCopy: false
+            icon.text: MaterialIcons.warning
+            parent: Overlay.overlay
+            preset: "Warning"
+            title: "Nodes have warnings"
+            text: "Some nodes have warnings, are you sure you want to submit ?"
+            helperText: "Submit even if some nodes have warnings"
+            standardButtons: Dialog.Cancel | Dialog.Ok
+
+            property var nodes: []
+
+            onDiscarded: close()
+            onAccepted: {
+                console.log("submit nodes", nodes)
+            }
+        }
+
         MessageDialog {
             id: fileModifiedDialog
 

meshroom/ui/qml/GraphEditor/AttributeItemDelegate.qml

@@ -445,7 +445,7 @@ RowLayout {
 
                 MaterialLabel {                
                     visible: !attribute.isOutput && errorMessages.length
-                    text: MaterialIcons.warning
+                    text: MaterialIcons.fmd_bad
                     ToolTip.text: errorMessages.join("\n")
                     color: "orange"
                 }

meshroom/ui/qml/GraphEditor/Node.qml

@@ -281,7 +281,7 @@ Item {
                             // Attribute warnings
                             MaterialLabel {
                                 visible: hasWarnings
-                                text: MaterialIcons.warning
+                                text: MaterialIcons.fmd_bad
                                 color: "orange"
                                 padding: 2
                                 font.pointSize: 7