Skip to content

Commit e704e5b

Browse files
authored
Merge pull request #2853 from alicevision/dev/improveSetup
[build] Package the scripts in `bin` alongside the executables
2 parents 59b15a7 + 37c6111 commit e704e5b

File tree

3 files changed

+7
-9
lines changed

3 files changed

+7
-9
lines changed

.git-blame-ignore-revs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
# [build] `setup.py`: Use double quotes everywhere
2+
571de38ef1a9e72e6c1d2a997b60de5bd3caa5bf
13
# [bin] `meshroom_batch`: Minor clean-up in the file
24
15d9ecd888faa7216cfc5d97d473f5717a3118a3
35
# [core] Linting following CI's flake8 report

meshroom/core/desc/node.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,8 @@
1515
from meshroom.core import cgroup
1616

1717
_MESHROOM_ROOT = Path(meshroom.__file__).parent.parent.as_posix()
18-
if getattr(sys, "frozen", False): # When in release package mode, the path to meshroom_compute differs
19-
_MESHROOM_COMPUTE = (Path(_MESHROOM_ROOT).parent / "meshroom_compute").as_posix()
20-
_MESHROOM_COMPUTE_EXE = _MESHROOM_COMPUTE
21-
else:
22-
_MESHROOM_COMPUTE = (Path(_MESHROOM_ROOT) / "bin" / "meshroom_compute").as_posix()
23-
_MESHROOM_COMPUTE_EXE = f"python {_MESHROOM_COMPUTE}"
18+
_MESHROOM_COMPUTE = (Path(_MESHROOM_ROOT) / "bin" / "meshroom_compute").as_posix()
19+
_MESHROOM_COMPUTE_EXE = f"python {_MESHROOM_COMPUTE}"
2420

2521

2622
class MrNodeType(enum.Enum):

setup.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ def __init__(self, script, initScript=None, base=None, targetName=None, icons=No
5858
"cmath",
5959
"numpy"
6060
],
61-
"include_files": ["CHANGES.md", "COPYING.md", "LICENSE-MPL2.md", "README.md"]
61+
"include_files": ["CHANGES.md", "COPYING.md", "LICENSE-MPL2.md", "README.md", "bin"]
6262
}
6363
if os.path.isdir(os.path.join(currentDir, "tractor")):
6464
build_exe_options["packages"].append("tractor")
@@ -143,9 +143,9 @@ def __init__(self, script, initScript=None, base=None, targetName=None, icons=No
143143
setup(
144144
name="Meshroom",
145145
description="Meshroom",
146-
install_requires=['psutil', 'pytest', 'PySide6', 'markdown'],
146+
install_requires=["psutil", "PySide6", "markdown"],
147147
setup_requires=[
148-
'cx_Freeze'
148+
"cx_Freeze"
149149
],
150150
version=meshroom.__version__,
151151
options={"build_exe": build_exe_options},

0 commit comments

Comments
 (0)