Skip to content

Commit f3e3fa8

Browse files
authored
Merge pull request #2903 from alicevision/dev/callableWarnings
[core] attribute: warning on failure inside node callables
2 parents b21ca05 + af2940f commit f3e3fa8

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

meshroom/core/attribute.py

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -220,9 +220,7 @@ def getDefaultValue(self):
220220
return self._desc.value(self)
221221
except Exception as e:
222222
if not self.node.isCompatibilityNode:
223-
# Log message only if we are not in compatibility mode
224-
logging.warning("Failed to evaluate default value (node lambda) for attribute '{}': {}".
225-
format(self.name, e))
223+
logging.warning(f"Failed to evaluate 'defaultValue' (node lambda) for attribute '{self.fullName}': {e}")
226224
return None
227225
# Need to force a copy, for the case where the value is a list
228226
# (avoid reference to the desc value)
@@ -284,7 +282,9 @@ def _isValid(self):
284282
if callable(self._desc.validValue):
285283
try:
286284
return self._desc.validValue(self.node)
287-
except Exception:
285+
except Exception as e:
286+
if not self.node.isCompatibilityNode:
287+
logging.warning(f"Failed to evaluate 'isValid' (node lambda) for attribute '{self.fullName}': {e}")
288288
return True
289289
return True
290290

@@ -345,8 +345,9 @@ def _getEnabled(self) -> bool:
345345
if callable(self._desc.enabled):
346346
try:
347347
return self._desc.enabled(self.node)
348-
except Exception:
349-
# Node implementation may fail due to version mismatch
348+
except Exception as e:
349+
if not self.node.isCompatibilityNode:
350+
logging.warning(f"Failed to evaluate 'enabled' (node lambda) for attribute '{self.fullName}': {e}")
350351
return True
351352
return self._desc.enabled
352353

0 commit comments

Comments
 (0)