Skip to content

Commit ff8c063

Browse files
committed
[core] Node: Do not automatically upgrade unknown nodes in templates
1 parent ebcbf9d commit ff8c063

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

meshroom/core/node.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1922,7 +1922,9 @@ def nodeFactory(nodeDict, name=None, template=False, uidConflict=False):
19221922
if not internalFolder and nodeDesc:
19231923
logging.warning("No serialized output data: performing automatic upgrade on '{}'".format(name))
19241924
node = node.upgrade()
1925-
elif template: # If the node comes from a template file and there is a conflict, it should be upgraded anyway
1925+
# If the node comes from a template file and there is a conflict, it should be upgraded anyway unless it is
1926+
# an "unknown node type" conflict (in which case the upgrade would fail)
1927+
elif template and compatibilityIssue is not CompatibilityIssue.UnknownNodeType:
19261928
node = node.upgrade()
19271929

19281930
return node

0 commit comments

Comments
 (0)