[core] Add support for keyable attributes #2878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregoire-dl
added
feature
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2878 +/- ##
===========================================
+ Coverage 79.52% 80.06% +0.53%
===========================================
Files 51 53 +2
Lines 6976 7225 +249
===========================================
+ Hits 5548 5785 +237
- Misses 1428 1440 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gregoire-dl
force-pushed
the
dev/attributeValues
branch
from
fff38b2 to
c5aba49
Compare
Allows to store a list of pairs (key, value) based on an attribute description.
- display value or default value at current viewId for keyable attribute. - allows to set/update current viewId value for keyable attribute. - new add/remove key button for keyable attribute.
- check keyable attribute initialization. - check keyable attribute CRUD. - check keyable attribute linked. - check keyable attribute UID.
Fix logic error, Attribute.getDefaultValue() is used in node serialization and represents the true default value of an attribute. In the case of a keyable attribute this should be an empty dict (no keys). We should use attribute description to get the default value of a key.
In this case, we can use SetAttributeCommand with attribute.getDefaultValue().
gregoire-dl
force-pushed
the
dev/attributeValues
branch
from
dc5b211 to
2587bc9
Compare
9 tasks
| checked: attribute.keyable && attribute.keyValues.hasKey(_reconstruction.selectedViewId) | ||
| enabled: root.editable | ||
| onClicked: { | ||
| if (attribute.keyValues.hasKey(_reconstruction.selectedViewId)) |
Member
There was a problem hiding this comment.
Should do nothing if there is no selected view ("selectedViewId" is "-1").
Member
There was a problem hiding this comment.
Or maybe globally lock the attribute when there is no selectedViewId.
Member
Author
There was a problem hiding this comment.
Thanks.
I made the changes to lock the attribute.
In any case, it's not possible to add an attribute value for a negative key, checked in KeyValues.add().
fabiencastan
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, all attributes were implicitly treated as non-keyable.
This PR introduces support for keyable attributes, allowing them to be loaded, stored, animated or manipulated.
Backward compatibility is preserved.
A test node with keyable attributes.
Current limitations and scope:
BoolParam,IntParam, andFloatParam.viewIdis currently supported as thekeyType.Unit tests cover:
Sample Node:
A sample node for testing: TestNode.zip
Features list
KeyValuesclass to manage the keyable attribute list of(key, value)pairs.BoolParam,IntParam, andFloatParam.AttributeItemDelegate.qmlImplementation remarks
This PR is designed in the context of developing the new shape editor.
It can serve as a foundation for full support of keyable attributes in the future.