[qml] ExpressionTextFields: Fix unwanted value updates #2911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anged` The `textChanged` variable created ambiguity, since `TextFields` already have a `textChanged()` signal. It was thus unclear when the `onTextChanged` slot was triggered. Renaming the `textChanged` property to `exprTextChanged` ensures that `onTextChanged` is only triggered when the content of the text field itself is changed by the user.
…hanged This prevents validating default `evaluatedValue` when the user has not performed any change.
If the `ExpressionTextField` is meant for an integer (`isInt = true`), then the value of the expression should be an integer, meaning rounding may need to be applied. However, for floating numbers, we do not want to lose some precision, so the value should never be rounded or set to a fixed number of decimal digits.
Floating numbers should not have a fixed number of decimals to avoid losing precision, so the `decimals` property is not needed anymore. References to it are removed in the HdrImageToolbar.
cbentejac
requested review from
Alxiice,
CedricThebault,
fabiencastan and
servantftransperfect
cbentejac
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2911 +/- ##
========================================
Coverage 80.61% 80.61%
========================================
Files 55 55
Lines 7692 7692
========================================
Hits 6201 6201
Misses 1491 1491 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CedricThebault
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a follow-up to #2836 and #2892 and prevents refreshing the status of the
ExpressionTextFieldwhen the text field has not been changed by the user. This fixes some unwanted value updates that would occur when a field was losing the focus despite having undergone no change at all.Additionally, floating values are not set to a fixed number of digits anymore, thus allowing to set precise floating values to attributes if desired.