[ui] Add support to initialize projects with templates including CopyOutputs nodes
#2949
+36
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To use `_loadWithErrorReport` without breaking it, a new slot that uses `initFromTemplate` with `copyOutputs=True` instead of `copyOutputs=False` (the default value) is added.
cbentejac
requested review from
Alxiice,
CedricThebault,
fabiencastan and
servantftransperfect
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2949 +/- ##
========================================
Coverage 80.82% 80.82%
========================================
Files 59 59
Lines 7844 7844
========================================
Hits 6340 6340
Misses 1504 1504 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an
--outputargument to Meshroom's command line. By using this argument and providing one or more output paths, Meshroom initializes a pipeline using a template and includes itsCopyFilesnodes (if it has any). Previously,CopyFilesnodes were automatically excluded from the pipeline initialization.This fixes #2934.
Features list
newWithCopyOutputsslot that initializes a project from a template and includes the template'sCopyFilesnodes.CopyFilesnodes.Implementation remarks
The
newWithCopyOutputsis created as such to be able to initialize a project from a template seemlessly with the error report (through_loadWithErrorReport). This prevents modifying the API to include acopyOutputsboolean that would have to be added everywhere, including in cases where we want to perform aload()rather than anew().