Non aligned free on Windows

[lxq2t]

Hi!
I have some faults on free of popsift::Features (Windows 64), seems to be freed of ori and ext should be called with aligned_free method.

[zvrba]

The problem lies in memalign function here:

popsift/src/popsift/common/assist.h

Line 127 in fb5251e

static void* memalign(size_t alignment, size_t size)

The rest of the code uses memalign to acquire memory, but the rest of the code uses free to free it. On Windows, memalign calls _aligned_malloc, and the example in documentation [1] explicitly states that using free is illegal). The effect of using free is what you have observed.

[1] https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/aligned-malloc?view=vs-2017

[griwodz]

Hi,
I changed the two places where free was called on ori and ext. The fix is in PR53. But I don't have Windows to check myself. Could you try the Pull request?

[simogasp]

closing this as fixed by #53