markNextVersion bumps patch to ONE not ZERO

[gabrieljones]

Patch and minor versions MUST be reset to 0 when major version is incremented.
https://semver.org/spec/v2.0.0.html

Expected

markNextVersion -Prelease.versionIncrementer=incrementMinor bumps from 2.4.5 to 2.5.0

Observed

markNextVersion -Prelease.versionIncrementer=incrementMinor bumps from 2.4.5 to 2.5.1

[bgalek]

@gabrieljones

I've wrote a quick unit test:

    def "should increment minor when incrementMinor rule used test"() {
        given:
        def context = new VersionIncrementerContext(Version.valueOf('2.4.5'), scmPosition('master'))
        expect:
        versionIncrementerFor('incrementMinor').apply(context) == Version.valueOf('2.5.0')
    }

and it works as expected, could you provide a test that shows the problem?
or a gradle build that shows whole picture?

[TimoFrye]

Hey,

i think i got the same Problem with Patch upgardes.
Mine upgrades just skip a number like 1.0.1 -> 1.0.3.

And i think i know why this happens. I debugged the plugin and found that in the Method the currentVersion is already increased. And will be increased again in the else part. That is the reason my patch versions are skipping one.

axion-release-plugin/src/main/groovy/pl/allegro/tech/build/axion/release/domain/NextVersionMarker.groovy

Line 20 in 5b331e6

void markNextVersion(NextVersionProperties nextVersionRules, TagProperties tagRules, VersionConfig versionConfig) {

` void markNextVersion(NextVersionProperties nextVersionRules, TagProperties tagRules, VersionConfig versionConfig) {

    String nextVersion = null
    if (nextVersionRules.nextVersion) {
        nextVersion = nextVersionRules.nextVersion
    } else {
        Version currentVersion = Version.valueOf(versionConfig.undecoratedVersion)
        VersionIncrementerContext context = new VersionIncrementerContext(currentVersion, repositoryService.position(), repositoryService.isLegacyDefTagnameRepo())
        nextVersion = nextVersionRules.versionIncrementer ?
            PredefinedVersionIncrementer.versionIncrementerFor(nextVersionRules.versionIncrementer).apply(context) :
            versionConfig.versionIncrementer.get().apply(context)
        logger.info("Next Version not specified. Creating next version with default incrementer: $nextVersion")
    }

    String tagName = tagRules.serialize.apply(tagRules, nextVersion.toString())
    String nextVersionTag = nextVersionRules.serializer.apply(nextVersionRules, tagName)

    logger.quiet("Creating next version marker tag: $nextVersionTag")
    repositoryService.tag(nextVersionTag)
    repositoryService.push()
}`

maybe you can have a look at it @bgalek
thank you =)