gwsocket as a library

[kempgc]

Love the way gwserver currently but wonder if anyone would have time to perhaps create a library (libgwserver.so) which does not include gwserver.c so the core code can be embedded inside another process and I do not have to run the gwserver separately.

[allinurl]

It shouldn't be too bad, I'm guessing the work involved would be to get rid of the gwserver.c file. I can look into it, not sure I can do it soon but I can certainly check it out.

Also, I'm thinking you could include those files in your project and work directly with the header files. Probably not as convenient but perhaps a quick solution.

[kempgc]

That would be excellent. I took a look at how the current Makefile is generated and decided it would take me too long to get up to speed on what was going on. Yes this would remove the need for gwserver.c however most of the code would be move across in particular the callbacks to support strict mode, parsing of parameters would not be needed. My current plan is to write a simple makefile which will create a libgwsocket.so.

If its ok with you I would like to update the code to remove many of the issues that Coverity (https://www.synopsys.com/software-integrity/security-testing.html) is finding, mainly NULL pointer checking etc. This is a server so security is important. Happy to push changes and once I have completed along with my code that demonstrates how to use if you wish.

[allinurl]

That would be awesome. Thanks!

[imatasic]

would this be something that could be used with apache web server?

[allinurl]

@imatasic what are you trying to achieve?

[imatasic]

@allinurl Well, I am struggling to get the boilerplate configuration for apache to proxy the websocket properly. Sometimes I have to use both proxypass and rewrite directive, sometimes only proxypass works and i think this might impact the performance.
not to mention it takes up an available connection from apache, so I have to increase that number as well.

example:

...
ServerName site.example.com
ProxyPreserveHost On
AllowEncodedSlashes NoDecode
SSLProxyEngine On

ProxyPass /wss  wss://192.168.14.20:8080/
ProxyPassReverse /wss wss://192.168.14.20:8080/
...
RewriteEngine on
RewriteCond %{HTTP:UPGRADE} ^WebSocket$ [NC]
RewriteCond %{HTTP:CONNECTION} ^Upgrade$ [NC]
RewriteRule .* wss://192.168.14.20:8080%{REQUEST_URI} [P]
...

This is the only way i found that I can access the websocket from both inside the network, and from the internet when I access https://site.example.com.

Maybe I am doing this completely wrong.
Is there a better way to do this with nginx?

[allinurl]

@imatasic if I understand correctly, gwsocket could help you achieve that. goaccess uses gwsocket on the back-end. There are some guides on how to get this done with apache, take a look at this guide.

[SamuelMarks]

@allinurl Would you be open to a CMake contribution?

I'm thinking adding library support [and native Windows MSVC] would be trivial once this is in place…

[allinurl]

@SamuelMarks That would be fantastic and greatly appreciated! are you thinking of replacing make with CMake, or having both options? I’d prefer the latter, if possible.