feat: fixed sync/async situation; made email a BackgroundTask

k9mil · k9mil · commit 8ec2aee12856 · 2025-11-05T08:23:19.000Z
diff --git a/backend/api/audio/controllers/audio_controller.py b/backend/api/audio/controllers/audio_controller.py
@@ -61,7 +61,7 @@ async def analyse_audio(
 
 
 @audio.post("/api/v1/audio/apply", response_model=list[EventBase])
-async def apply_recommendations(  # noqa: PLR0913
+def apply_recommendations(  # noqa: PLR0913
     analysis_output: AudioAnalysisOutput,
     apply_recommendations_use_case: Annotated[
         ApplyRecommendationsUseCase,
@@ -81,7 +81,7 @@ async def apply_recommendations(  # noqa: PLR0913
     ],
     current_user: Annotated[str, Depends(get_current_user)],
 ):
-    return await apply_recommendations_use_case.execute(
+    return apply_recommendations_use_case.execute(
         current_user,
         analysis_output.llm_output,
         create_event_use_case,
diff --git a/backend/api/audio/use_cases/apply_recommendations_use_case.py b/backend/api/audio/use_cases/apply_recommendations_use_case.py
@@ -23,7 +23,7 @@ def __init__(
     ) -> None:
         self.user_repository = user_repository
 
-    async def execute(
+    def execute(
         self,
         current_user: str,
         recommendations: str,
diff --git a/backend/api/services/email_service.py b/backend/api/services/email_service.py
@@ -10,7 +10,7 @@ def __init__(self) -> None:
         self.url = PLUNK_URL
         self.api_key = config.PLUNK_API_KEY
 
-    def send_welcome_email(self, recipient: str) -> None:
+    async def send_welcome_email(self, recipient: str) -> None:
         self.body = """
 <!DOCTYPE html>
 <html lang="en">
@@ -70,4 +70,5 @@ def send_welcome_email(self, recipient: str) -> None:
             "Authorization": f"Bearer {self.api_key}",
         }
 
-        httpx.request("POST", self.url, json=payload, headers=headers)
+        async with httpx.AsyncClient() as client:
+            await client.request("POST", self.url, json=payload, headers=headers)
diff --git a/backend/api/users/controllers/users_controller.py b/backend/api/users/controllers/users_controller.py
@@ -1,6 +1,13 @@
 from typing import Annotated
 
-from fastapi import APIRouter, Depends, HTTPException, Request, Response
+from fastapi import (
+    APIRouter,
+    BackgroundTasks,
+    Depends,
+    HTTPException,
+    Request,
+    Response,
+)
 from fastapi.security import OAuth2PasswordRequestForm
 
 from api.config import config
@@ -33,6 +40,7 @@
 @users.post("/api/v1/users")
 def register_user(
     request: UserDetails,
+    background_tasks: BackgroundTasks,
     register_user_use_case: Annotated[
         RegisterUserUseCase,
         Depends(register_user_use_case),
@@ -62,7 +70,7 @@ def register_user(
             detail=validation_password_errors,
         )
 
-    return register_user_use_case.execute(request)
+    return register_user_use_case.execute(request, background_tasks)
 
 
 @users.post("/api/v1/users/login")
diff --git a/backend/api/users/use_cases/register_user_use_case.py b/backend/api/users/use_cases/register_user_use_case.py
@@ -1,3 +1,5 @@
+from fastapi import BackgroundTasks
+
 from api.services.email_service import EmailService
 from api.system.interfaces.use_cases import UseCase
 from api.system.models.models import User
@@ -19,7 +21,9 @@ def __init__(
         self.bcrypt_hasher = bcrypt_hasher
         self.email_service = email_service
 
-    def execute(self, request: UserDetails) -> UserSchema:
+    def execute(
+        self, request: UserDetails, background_tasks: BackgroundTasks
+    ) -> UserSchema:
         if self.user_repository.find_by_email(request.email_address):
             msg = "User already exists."
             raise UserAlreadyExistsError(msg)
@@ -34,6 +38,9 @@ def execute(self, request: UserDetails) -> UserSchema:
         )
 
         self.user_repository.add(user)
-        self.email_service.send_welcome_email(str(user.email_address))
+        background_tasks.add_task(
+            self.email_service.send_welcome_email,
+            str(user.email_address),
+        )
 
         return user
