chore(provider)!: rename on_* to connect_* (#2225)

* chore(`provider`): rename builder methods

* fix

* fmt

* fix

* nit

Author: yash-atreya

crates/contract/src/call.rs

@@ -160,7 +160,7 @@ impl<P, D, N: Network> CallBuilder<P, D, N> {
     ///
     /// #[tokio::main]
     /// async fn main() {
-    ///     let provider = ProviderBuilder::new().on_anvil_with_wallet();
+    ///     let provider = ProviderBuilder::new().connect_anvil_with_wallet();
     ///
     ///     let my_contract = Counter::deploy(provider).await.unwrap();
     ///
@@ -202,7 +202,7 @@ impl<P, D, N: Network> CallBuilder<P, D, N> {
     ///
     /// #[tokio::main]
     /// async fn main() {
-    ///     let provider = ProviderBuilder::new().on_anvil_with_wallet();
+    ///     let provider = ProviderBuilder::new().connect_anvil_with_wallet();
     ///
     ///     let my_contract = Counter::deploy(&provider).await.unwrap();
     ///
@@ -328,7 +328,7 @@ impl<P: Provider<N>, N: Network> RawCallBuilder<P, N> {
     /// # stringify!(
     /// let provider = ...;
     /// # );
-    /// # let provider = alloy_provider::ProviderBuilder::new().on_anvil();
+    /// # let provider = alloy_provider::ProviderBuilder::new().connect_anvil();
     /// let call_builder = MyContract::deploy_builder(&provider)
     ///     .with_sol_decoder::<MyContract::constructorReturnCall>();
     /// let result = call_builder.call().await?;
@@ -635,7 +635,7 @@ mod tests {
             }
         }
 
-        let provider = ProviderBuilder::new().on_anvil();
+        let provider = ProviderBuilder::new().connect_anvil();
         let call_builder = EmptyConstructor::deploy_builder(&provider);
         assert_eq!(*call_builder.calldata(), bytes!("6942"));
     }
@@ -671,9 +671,8 @@ mod tests {
     }
 
     /// Creates a new call_builder to test field modifications, taken from [call_encoding]
-    #[allow(clippy::type_complexity)]
     fn build_call_builder() -> CallBuilder<impl Provider, PhantomData<MyContract::doStuffCall>> {
-        let provider = ProviderBuilder::new().on_anvil();
+        let provider = ProviderBuilder::new().connect_anvil();
         let contract = MyContract::new(Address::ZERO, provider);
         let call_builder = contract.doStuff(U256::ZERO, true).with_cloned_provider();
         call_builder
@@ -738,7 +737,7 @@ mod tests {
 
     #[test]
     fn call_encoding() {
-        let provider = ProviderBuilder::new().on_anvil();
+        let provider = ProviderBuilder::new().connect_anvil();
         let contract = MyContract::new(Address::ZERO, &&provider).with_cloned_provider();
         let call_builder = contract.doStuff(U256::ZERO, true).with_cloned_provider();
         assert_eq!(
@@ -756,7 +755,7 @@ mod tests {
 
     #[test]
     fn deploy_encoding() {
-        let provider = ProviderBuilder::new().on_anvil();
+        let provider = ProviderBuilder::new().connect_anvil();
         let bytecode = &MyContract::BYTECODE[..];
         let call_builder = MyContract::deploy_builder(&provider, false);
         assert_eq!(
@@ -780,7 +779,7 @@ mod tests {
 
     #[tokio::test(flavor = "multi_thread")]
     async fn deploy_and_call() {
-        let provider = ProviderBuilder::new().on_anvil_with_wallet();
+        let provider = ProviderBuilder::new().connect_anvil_with_wallet();
 
         let expected_address = provider.default_signer_address().create(0);
         let my_contract = MyContract::deploy(provider, true).await.unwrap();
@@ -806,7 +805,7 @@ mod tests {
 
     #[tokio::test(flavor = "multi_thread")]
     async fn deploy_and_call_with_priority() {
-        let provider = ProviderBuilder::new().on_anvil_with_wallet();
+        let provider = ProviderBuilder::new().connect_anvil_with_wallet();
         let counter_contract = Counter::deploy(provider.clone()).await.unwrap();
         let max_fee_per_gas: U256 = parse_units("50", "gwei").unwrap().into();
         let max_priority_fee_per_gas: U256 = parse_units("0.1", "gwei").unwrap().into();
@@ -859,7 +858,8 @@ mod tests {
 
         let wallet = EthereumWallet::new(pk);
 
-        let wallet_provider = ProviderBuilder::new().wallet(wallet).on_http(anvil.endpoint_url());
+        let wallet_provider =
+            ProviderBuilder::new().wallet(wallet).connect_http(anvil.endpoint_url());
 
         let contract = SendMoney::deploy(wallet_provider.clone()).await.unwrap();
 
@@ -870,7 +870,7 @@ mod tests {
 
         assert!(tx.from.is_none());
 
-        let std_provider = ProviderBuilder::new().on_http(anvil.endpoint_url());
+        let std_provider = ProviderBuilder::new().connect_http(anvil.endpoint_url());
         let should_fail = std_provider.estimate_gas(tx.clone()).await.is_err();
 
         assert!(should_fail);
@@ -897,7 +897,7 @@ mod tests {
             }
         }
 
-        let provider = ProviderBuilder::new().on_anvil_with_wallet();
+        let provider = ProviderBuilder::new().connect_anvil_with_wallet();
 
         let contract = RetStruct::deploy(provider.clone()).await.unwrap();
 

crates/contract/src/error.rs

@@ -91,7 +91,7 @@ impl Error {
     ///
     /// #[tokio::main]
     /// async fn main() {
-    ///     let provider = ProviderBuilder::new().on_anvil_with_wallet();
+    ///     let provider = ProviderBuilder::new().connect_anvil_with_wallet();
     ///
     ///     let throws_err = ThrowsError::deploy(provider).await.unwrap();
     ///
@@ -136,7 +136,7 @@ impl Error {
     ///
     /// #[tokio::main]
     /// async fn main() {
-    ///     let provider = ProviderBuilder::new().on_anvil_with_wallet();
+    ///     let provider = ProviderBuilder::new().connect_anvil_with_wallet();
     ///
     ///     let throws_err = ThrowsError::deploy(provider).await.unwrap();
     ///

crates/contract/src/event.rs

@@ -315,7 +315,7 @@ mod tests {
         let wallet = EthereumWallet::from(pk);
         let provider = alloy_provider::ProviderBuilder::new()
             .wallet(wallet.clone())
-            .on_http(anvil.endpoint_url());
+            .connect_http(anvil.endpoint_url());
 
         // let from = address!("f39Fd6e51aad88F6F4ce6aB8827279cffFb92266");
         let contract = MyContract::deploy(&provider).await.unwrap();
@@ -423,7 +423,7 @@ mod tests {
         let wallet = EthereumWallet::from(pk);
         let provider = alloy_provider::ProviderBuilder::new()
             .wallet(wallet.clone())
-            .on_http(anvil.endpoint_url());
+            .connect_http(anvil.endpoint_url());
 
         let contract = MyContract::deploy(&provider).await.unwrap();
 

crates/contract/src/instance.rs

@@ -127,7 +127,7 @@ mod tests {
 
     #[tokio::test]
     async fn contract_interface() {
-        let provider = ProviderBuilder::new().on_anvil_with_wallet();
+        let provider = ProviderBuilder::new().connect_anvil_with_wallet();
 
         let abi_str = r#"[{"inputs":[],"name":"counter","outputs":[{"internalType":"uint256","name":"","type":"uint256"}],"stateMutability":"view","type":"function"},{"inputs":[],"name":"increment","outputs":[],"stateMutability":"nonpayable","type":"function"}]"#;
         let abi = serde_json::from_str::<JsonAbi>(abi_str).unwrap();

crates/contract/src/multicall.rs

@@ -65,7 +65,7 @@ mod tests {
     #[tokio::test]
     async fn test_single() {
         let weth = address!("C02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2");
-        let provider = ProviderBuilder::new().on_anvil_with_config(|a| a.fork(FORK_URL));
+        let provider = ProviderBuilder::new().connect_anvil_with_config(|a| a.fork(FORK_URL));
 
         let erc20 = ERC20::new(weth, &provider);
         let multicall = provider.multicall().add(erc20.totalSupply());
@@ -76,7 +76,7 @@ mod tests {
     #[tokio::test]
     async fn test_aggregate() {
         let weth = address!("C02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2");
-        let provider = ProviderBuilder::new().on_anvil_with_config(|a| a.fork(FORK_URL));
+        let provider = ProviderBuilder::new().connect_anvil_with_config(|a| a.fork(FORK_URL));
 
         let erc20 = ERC20::new(weth, &provider);
 
@@ -96,7 +96,7 @@ mod tests {
     #[tokio::test]
     async fn test_try_aggregate_pass() {
         let weth = address!("C02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2");
-        let provider = ProviderBuilder::new().on_anvil_with_config(|a| a.fork(FORK_URL));
+        let provider = ProviderBuilder::new().connect_anvil_with_config(|a| a.fork(FORK_URL));
         let erc20 = ERC20::new(weth, &provider);
 
         let multicall = provider
@@ -113,8 +113,9 @@ mod tests {
     async fn aggregate3() {
         let weth = address!("C02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2");
 
-        let provider =
-            ProviderBuilder::new().on_anvil_with_wallet_and_config(|a| a.fork(FORK_URL)).unwrap();
+        let provider = ProviderBuilder::new()
+            .connect_anvil_with_wallet_and_config(|a| a.fork(FORK_URL))
+            .unwrap();
 
         let dummy = deploy_dummy(provider.clone()).await;
         let erc20 = ERC20::new(weth, &provider);
@@ -145,8 +146,9 @@ mod tests {
     #[tokio::test]
     async fn test_try_aggregate_fail() {
         let weth = address!("C02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2");
-        let provider =
-            ProviderBuilder::new().on_anvil_with_wallet_and_config(|a| a.fork(FORK_URL)).unwrap();
+        let provider = ProviderBuilder::new()
+            .connect_anvil_with_wallet_and_config(|a| a.fork(FORK_URL))
+            .unwrap();
 
         let dummy_addr = deploy_dummy(provider.clone()).await;
         let erc20 = ERC20::new(weth, &provider);
@@ -176,7 +178,7 @@ mod tests {
     async fn test_util() {
         let weth = address!("C02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2");
         let provider = ProviderBuilder::new()
-            .on_anvil_with_config(|a| a.fork(FORK_URL).fork_block_number(21787144));
+            .connect_anvil_with_config(|a| a.fork(FORK_URL).fork_block_number(21787144));
         let erc20 = ERC20::new(weth, &provider);
         let multicall = provider
             .multicall()
@@ -212,8 +214,9 @@ mod tests {
 
     #[tokio::test]
     async fn aggregate3_value() {
-        let provider =
-            ProviderBuilder::new().on_anvil_with_wallet_and_config(|a| a.fork(FORK_URL)).unwrap();
+        let provider = ProviderBuilder::new()
+            .connect_anvil_with_wallet_and_config(|a| a.fork(FORK_URL))
+            .unwrap();
 
         let payable_counter = PayableCounter::deploy(provider.clone()).await.unwrap();
 
@@ -258,7 +261,7 @@ mod tests {
     #[tokio::test]
     async fn test_clear() {
         let weth = address!("C02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2");
-        let provider = ProviderBuilder::new().on_anvil();
+        let provider = ProviderBuilder::new().connect_anvil();
 
         let erc20 = ERC20::new(weth, &provider);
         let multicall = provider
@@ -273,7 +276,7 @@ mod tests {
     #[tokio::test]
     async fn add_dynamic() {
         let weth = address!("C02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2");
-        let provider = ProviderBuilder::new().on_anvil_with_config(|a| a.fork(FORK_URL));
+        let provider = ProviderBuilder::new().connect_anvil_with_config(|a| a.fork(FORK_URL));
 
         let erc20 = ERC20::new(weth, &provider);
 
@@ -295,7 +298,7 @@ mod tests {
     #[tokio::test]
     async fn test_extend_dynamic() {
         let weth = address!("C02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2");
-        let provider = ProviderBuilder::new().on_anvil_with_config(|a| a.fork(FORK_URL));
+        let provider = ProviderBuilder::new().connect_anvil_with_config(|a| a.fork(FORK_URL));
         let erc20 = ERC20::new(weth, &provider);
         let ts_calls = vec![erc20.totalSupply(); 18];
         let multicall = MulticallBuilder::new_dynamic(provider.clone()).extend(ts_calls);