Skip to content

Commit 21f3006

Browse files
dcearaputnopvut
authored andcommitted
tests: Fix flaky "Loadbalancer add-route option" system test.
When the test toggles add_route from true to false, the OpenFlow routing rules are removed after --wait=hv, but stale megaflow entries cached in the OVS datapath from the previous successful pings may survive until the revalidator timer fires. The first ping packet can match such a stale flow and get forwarded, causing an intermittent "1 received" instead of "0 received". Wait for datapath revalidation after the configuration change to avoid the race. Other system tests that toggle connectivity on and off may suffer from the same class of issue, but this one happens to fail more often in CI, e.g.: https://github.com/dceara/ovn/actions/runs/26631517208/job/78481704883#step:11:6606 Assisted-by: Claude Opus 4.6, Claude Code Signed-off-by: Dumitru Ceara <dceara@redhat.com> Acked-by: Ales Musil <amusil@redhat.com> Signed-off-by: Mark Michelson <mmichels@redhat.com>
1 parent a21b011 commit 21f3006

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

tests/system-ovn.at

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14448,6 +14448,8 @@ NS_CHECK_EXEC([vm1], [ping -q -c 3 -i 0.3 -w 2 172.18.1.12 | FORMAT_PING], \
1444814448
])
1444914449

1445014450
check ovn-nbctl --wait=hv set load_balancer lb0 options:add_route=false
14451+
# Wait for revalidation of stale megaflows which may lag behind.
14452+
check ovs-appctl revalidator/wait
1445114453
NS_CHECK_EXEC([vm1], [ping -q -c 3 -i 0.3 -w 2 172.18.1.12 | FORMAT_PING], \
1445214454
[0], [dnl
1445314455
7 packets transmitted, 0 received, 100% packet loss, time 0ms

0 commit comments

Comments
 (0)