Skip to content

Commit 5ad50ff

Browse files
almusildceara
authored andcommitted
northd: Add missing feature change checks.
The feature change check was missing a bunch of flags. Add all of them so the I-P can properly propagate the change. Fixes: 43f741c ("northd: Explicitly handle SNAT for ICMP need frag.") Fixes: d9c9787 ("actions: New action ct_commit_to_zone.") Fixes: 7175214 ("features: Add detection for sample with registers.") Fixes: 8114a5c ("northd, controller: Use ct_next to get the CT state for direct SNAT.") Fixes: 0d3203c ("chassis: Check for ability to flush using CT label/mark.") Fixes: a087057 ("lib: northd: Add a new ct-state-save feature flag.") Signed-off-by: Ales Musil <amusil@redhat.com> Signed-off-by: Dumitru Ceara <dceara@redhat.com> (cherry picked from commit 45fcde5)
1 parent 64195cd commit 5ad50ff

1 file changed

Lines changed: 16 additions & 0 deletions

File tree

northd/en-global-config.c

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -621,5 +621,21 @@ chassis_features_changed(const struct chassis_features *present,
621621
return true;
622622
}
623623

624+
if (present->ct_commit_nat_v2 != updated->ct_commit_nat_v2) {
625+
return true;
626+
}
627+
628+
if (present->ct_commit_to_zone != updated->ct_commit_to_zone) {
629+
return true;
630+
}
631+
632+
if (present->ct_next_zone != updated->ct_next_zone) {
633+
return true;
634+
}
635+
636+
if (present->ct_state_save != updated->ct_state_save) {
637+
return true;
638+
}
639+
624640
return false;
625641
}

0 commit comments

Comments
 (0)