Skip to content

Commit 8eccb22

Browse files
igsilyaalmusil
authored andcommitted
system-kmod-macros: Load modern nf_conntrack modules.
Modules were renamed around kernel 4.18. New name doesn't have the protocol version. Also, we need to load the netlink module to have access to conntrack dumps. While these modules are likely to always be present and not actually be unloadable due to being in use by many different things in the system, they may not be loaded in minimalistic environments like virtme-ng. And tests fail without them. Same change was merged into OVS recently. Signed-off-by: Ilya Maximets <i.maximets@ovn.org> Signed-off-by: Ales Musil <amusil@redhat.com>
1 parent cf41894 commit 8eccb22

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

tests/system-kmod-macros.at

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,13 @@ m4_define([CONFIGURE_VETH_OFFLOADS],
6363
# Perform requirements checks for running conntrack tests, and flush the
6464
# kernel conntrack tables when the test is finished.
6565
#
66+
# nf_conntrack_ipv[46] are old names in kernels before 4.18. These will
67+
# fail on newer kernels, while nf_conntrack will fail on older ones. But
68+
# these failures do not affect the test execution.
69+
#
6670
m4_define([CHECK_CONNTRACK],
67-
m4_foreach([mod], [[nf_conntrack_ipv4], [nf_conntrack_ipv6]],
71+
m4_foreach([mod], [[nf_conntrack_ipv4], [nf_conntrack_ipv6],
72+
[nf_conntrack], [nf_conntrack_netlink]],
6873
[modprobe mod && on_exit 'modprobe -r mod' || echo "Module mod not loaded."
6974
])
7075
sysctl -w net.netfilter.nf_conntrack_helper=0

0 commit comments

Comments
 (0)