Skip to content

Commit 9f04b8c

Browse files
dcearaputnopvut
authored andcommitted
tests: Fix flaky "Loadbalancer add-route option" system test.
When the test toggles add_route from true to false, the OpenFlow routing rules are removed after --wait=hv, but stale megaflow entries cached in the OVS datapath from the previous successful pings may survive until the revalidator timer fires. The first ping packet can match such a stale flow and get forwarded, causing an intermittent "1 received" instead of "0 received". Wait for datapath revalidation after the configuration change to avoid the race. Other system tests that toggle connectivity on and off may suffer from the same class of issue, but this one happens to fail more often in CI, e.g.: https://github.com/dceara/ovn/actions/runs/26631517208/job/78481704883#step:11:6606 Assisted-by: Claude Opus 4.6, Claude Code Signed-off-by: Dumitru Ceara <dceara@redhat.com> Acked-by: Ales Musil <amusil@redhat.com> Signed-off-by: Mark Michelson <mmichels@redhat.com>
1 parent 79350ef commit 9f04b8c

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

tests/system-ovn.at

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14866,6 +14866,8 @@ NS_CHECK_EXEC([vm1], [ping -q -c 3 -i 0.3 -w 2 172.18.1.12 | FORMAT_PING], \
1486614866
])
1486714867

1486814868
check ovn-nbctl --wait=hv set load_balancer lb0 options:add_route=false
14869+
# Wait for revalidation of stale megaflows which may lag behind.
14870+
check ovs-appctl revalidator/wait
1486914871
NS_CHECK_EXEC([vm1], [ping -q -c 3 -i 0.3 -w 2 172.18.1.12 | FORMAT_PING], \
1487014872
[0], [dnl
1487114873
7 packets transmitted, 0 received, 100% packet loss, time 0ms

0 commit comments

Comments
 (0)