Skip to content

Commit ed52ac1

Browse files
committed
more
1 parent 3ca7179 commit ed52ac1

4 files changed

Lines changed: 16 additions & 16 deletions

File tree

devtools/gradle/gradle-application-plugin/src/main/java/io/quarkus/gradle/QuarkusPlugin.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -520,9 +520,10 @@ private static void configureApplicationModelTask(Project project, QuarkusApplic
520520
task.getLaunchMode().set(launchMode);
521521
task.getTypeModel().set(task.getPath());
522522
task.getOriginalClasspath().setFrom(classpath.getOriginalRuntimeClasspathAsInput());
523-
task.getAppClasspath().configureFrom(classpath.getRuntimeConfigurationWithoutResolvingDeployment(), launchMode);
524-
task.getPlatformConfiguration().configureFrom(classpath.getPlatformConfiguration(), launchMode);
525-
task.getDeploymentClasspath().configureFrom(classpath.getDeploymentConfiguration(), launchMode);
523+
task.getAppClasspath().configureFrom(classpath.getRuntimeConfigurationWithoutResolvingDeployment(), launchMode,
524+
project.getName());
525+
task.getPlatformConfiguration().configureFrom(classpath.getPlatformConfiguration(), launchMode, project.getName());
526+
task.getDeploymentClasspath().configureFrom(classpath.getDeploymentConfiguration(), launchMode, project.getName());
526527
task.getDeploymentResolvedWorkaround().from(classpath.getDeploymentConfiguration().getIncoming().getFiles());
527528
task.getPlatformImports().set(classpath.getPlatformImportsWithoutResolvingPlatform());
528529
task.getApplicationModel().set(project.getLayout().getBuildDirectory().file(quarkusModelFile));

devtools/gradle/gradle-application-plugin/src/main/java/io/quarkus/gradle/tasks/QuarkusApplicationModelTask.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -553,11 +553,10 @@ private QuarkusResolvedArtifact toResolvedArtifact(ResolvedArtifactResult result
553553
return new QuarkusResolvedArtifact(result.getId(), file, type);
554554
}
555555

556-
public void configureFrom(Configuration configuration, LaunchMode mode) {
556+
public void configureFrom(Configuration configuration, LaunchMode mode, String appName) {
557557
ResolvableDependencies resolvableDependencies = configuration.getIncoming();
558558
getRoot().set(resolvableDependencies.getResolutionResult().getRootComponent());
559559
getResolvedArtifactCollection().set(resolvableDependencies.getArtifacts());
560-
final String appName = resolvableDependencies.getResolutionResult().getRoot().getModuleVersion().getName();
561560
// TODO: Remove me, since we don't apply workspace plugin anymore, so there are no project descriptors
562561
getProjectDescriptors().setFrom(configuration.getIncoming().artifactView(viewConfiguration -> {
563562
// Project descriptors make sense only for projects
@@ -566,8 +565,7 @@ public void configureFrom(Configuration configuration, LaunchMode mode) {
566565
viewConfiguration.attributes(attributes -> {
567566
attributes.attribute(ArtifactTypeDefinition.ARTIFACT_TYPE_ATTRIBUTE,
568567
QUARKUS_PROJECT_DESCRIPTOR_ARTIFACT_TYPE);
569-
attributes.attribute(DeploymentConfigurationResolver.getQuarkusDeploymentAttribute(appName, mode),
570-
DeploymentConfigurationResolver.getQuarkusDeploymentAttributeValue());
568+
DeploymentConfigurationResolver.setDeploymentAttributes(attributes, appName, mode);
571569
ConditionalDependencyResolver.setConditionalAttributes(attributes, appName, mode);
572570
});
573571
}).getFiles());

devtools/gradle/gradle-model/src/main/java/io/quarkus/gradle/dependency/ConditionalDependencyResolver.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public static Attribute<String> getQuarkusConditionalDependencyAttribute(String
5151
}
5252

5353
public static void setConditionalAttributes(AttributeContainer attributes, String appName, LaunchMode mode) {
54-
attributes.attribute(ConditionalDependencyResolver.getQuarkusConditionalDependencyAttribute(appName, mode), ON);
54+
attributes.attribute(getQuarkusConditionalDependencyAttribute(appName, mode), ON);
5555
}
5656

5757
public static void resolve(Project project, LaunchMode mode, TaskDependencyFactory taskDependencyFactory) {

devtools/gradle/gradle-model/src/main/java/io/quarkus/gradle/dependency/DeploymentConfigurationResolver.java

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
public class DeploymentConfigurationResolver {
3232

3333
private static final byte COLLECT_TOP_EXTENSIONS = 0b001;
34+
private static final String ON = "on";
3435

3536
public static Attribute<String> getQuarkusDeploymentAttribute(String projectName, LaunchMode mode) {
3637
var sb = new StringBuilder().append(projectName)
@@ -41,8 +42,12 @@ public static Attribute<String> getQuarkusDeploymentAttribute(String projectName
4142
return Attribute.of(sb.toString(), String.class);
4243
}
4344

44-
public static String getQuarkusDeploymentAttributeValue() {
45-
return "on";
45+
public static void setDeploymentAttributes(AttributeContainer attributes, String appName, LaunchMode mode) {
46+
selectDeploymentAttribute(attributes, getQuarkusDeploymentAttribute(appName, mode));
47+
}
48+
49+
private static void selectDeploymentAttribute(AttributeContainer attrs, Attribute<String> attr) {
50+
attrs.attribute(attr, ON);
4651
}
4752

4853
public static void registerDeploymentConfiguration(Project project, LaunchMode mode, String configurationName,
@@ -86,7 +91,7 @@ private DeploymentConfigurationResolver(Project project, Configuration deploymen
8691
})));
8792
final String appName = project.getName();
8893
deploymentConfig.attributes(attrs -> {
89-
attrs.attribute(quarkusDepAttr, getQuarkusDeploymentAttributeValue());
94+
selectDeploymentAttribute(attrs, quarkusDepAttr);
9095
ConditionalDependencyResolver.setConditionalAttributes(attrs, appName, mode);
9196
});
9297
}
@@ -178,7 +183,7 @@ static void addDeploymentVariant(Attribute<String> attribute,
178183
private static void addDeploymentVariant(Attribute<String> attribute, ComponentMetadataDetails compDetails,
179184
Dependency deploymentDependency, String baseVariant) {
180185
compDetails.maybeAddVariant(attribute.getName(), baseVariant, variant -> {
181-
variant.attributes(attrs -> selectDeploymentAttribute(attribute, attrs));
186+
variant.attributes(attrs -> selectDeploymentAttribute(attrs, attribute));
182187
variant.withDependencies(directDeps -> {
183188
boolean alreadyAdded = false;
184189
for (var directDep : directDeps) {
@@ -195,10 +200,6 @@ private static void addDeploymentVariant(Attribute<String> attribute, ComponentM
195200
});
196201
}
197202

198-
static void selectDeploymentAttribute(Attribute<String> attr, AttributeContainer attrs) {
199-
attrs.attribute(attr, getQuarkusDeploymentAttributeValue());
200-
}
201-
202203
private Dependency getDeploymentDependency(ExtensionDependency<?> ext) {
203204
return ext.isProjectDependency()
204205
? DependencyUtils.createDeploymentProjectDependency((Project) ext.getDeploymentModule(), taskDependencyFactory)

0 commit comments

Comments
 (0)