Skip to content

Commit 3deb0eb

Browse files
committed
fix lints
1 parent 316fe2c commit 3deb0eb

File tree

5 files changed

+11
-13
lines changed

5 files changed

+11
-13
lines changed

.github/workflows/lint.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,10 @@ jobs:
2727
with:
2828
cache-on-failure: true
2929
# Currently, sp1 and risc0 guest builds are skipped when it is invoked under clippy.
30-
# This makes the whole build of clippy fail, so we run clippy on crates and examples.
31-
- name: Run clippy on crates/
30+
# This makes the whole build of clippy fail, so we run clippy on adapters and examples.
31+
- name: Run clippy on adapters/
3232
run: |
33-
find crates/ -type f -name "Cargo.toml" \
33+
find adapters/ -type f -name "Cargo.toml" \
3434
-exec sh -c \
3535
'f="$1"; echo "Clippy for ${f}" && \
3636
cargo clippy --manifest-path ${f} --all-features -- -D warnings' shell {} \;

Makefile

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,7 @@ help: ## Display this help.
3030

3131
.PHONY: build
3232
build: ## Build the workspace into the `target` directory.
33-
cargo build --workspace --bin "zkvm-runner" --features "$(FEATURES)" --profile "$(PROFILE)"
34-
33+
cargo build --workspace --bin "zkaleido-runner" --features "$(FEATURES)" --profile "$(PROFILE)"
3534
##@ Test
3635

3736
UNIT_TEST_ARGS := --locked --workspace -E 'kind(lib)' -E 'kind(bin)' -E 'kind(proc-macro)'
@@ -116,7 +115,7 @@ endef
116115

117116
.PHONY: lint-check-ws
118117
lint-check-ws: ## Checks for lint issues in the workspace.
119-
$(call lint-pkg,examples) && $(call lint-pkg,crates)
118+
$(call lint-pkg,examples) && $(call lint-pkg,adapters)
120119

121120
define lint-pkg-fix
122121
find $(1) -type f -name "Cargo.toml" -exec sh -c \
@@ -126,7 +125,7 @@ endef
126125

127126
.PHONY: lint-fix-ws
128127
lint-fix-ws: ## Lints the workspace and applies fixes where possible.
129-
$(call lint-pkg-fix,examples) && $(call lint-pkg-fix,crates)
128+
$(call lint-pkg-fix,examples) && $(call lint-pkg-fix,adapters)
130129

131130
ensure-codespell:
132131
@if ! command -v codespell &> /dev/null; then \

README.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -147,11 +147,10 @@ This will remove all `.trace_profile` and `.proof` files from the current direct
147147

148148
5. **Generate and dump Risc0 Proof**
149149
```bash
150-
make proof ZKVM=risc0 PROGRAMS=fibonacci
150+
make proof ZKVM=risc0 PROGRAMS=fibonacci
151151
```
152152

153-
154-
5. **Clean Up Generated Data:**
153+
6. **Clean Up Generated Data:**
155154
```bash
156155
make prover-clean
157156
```
@@ -161,7 +160,7 @@ This will remove all `.trace_profile` and `.proof` files from the current direct
161160

162161
## Adding Support for New ZKVMs
163162
To add support for a new ZKVM:
164-
1. Create a new adapter in the `crates/` directory.
163+
1. Create a new adapter in the `adapters/` directory.
165164
2. Implement the core traits required to interface with the ZKVM.
166165
3. Extend the artifact generation logic in `artifacts/` as needed.
167166

examples/fibonacci/src/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,8 @@ impl ZkVmProver for FibProver {
5353
mod tests {
5454
use std::sync::Arc;
5555

56-
use zkaleido_native_adapter::{NativeHost, NativeMachine};
5756
use zkaleido::ZkVmProver;
57+
use zkaleido_native_adapter::{NativeHost, NativeMachine};
5858

5959
use super::process_fib;
6060
use crate::FibProver;

runner/src/programs/sha2.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ fn sha2_prover_perf_report(host: &impl ZkVmHost) -> ProofReport {
88

99
#[cfg(feature = "sp1")]
1010
pub fn sp1_sha_report() -> ProofReport {
11-
use zkaleido_sp1_adapter::SP1Host;
1211
use strata_sp1_artifacts::SHA2_CHAIN_ELF;
12+
use zkaleido_sp1_adapter::SP1Host;
1313
let host = SP1Host::init(SHA2_CHAIN_ELF);
1414

1515
sha2_prover_perf_report(&host)

0 commit comments

Comments
 (0)