Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable hint #186

Closed
wants to merge 5 commits into from
Closed

Disable hint #186

wants to merge 5 commits into from

Conversation

carolinegreen
Copy link

@carolinegreen carolinegreen commented Jul 7, 2017

Allow users to hide the hint when using autoselect. Closes #120.

With hint:

screen shot 2017-07-07 at 14 41 06 1

Without:

screen shot 2017-07-07 at 14 41 21

@tvararu tvararu temporarily deployed to accessible-autocomplete-pr-186 July 7, 2017 10:36 Inactive
@edwardhorsford
Copy link
Contributor

Can you include before and after screenshots?

@carolinegreen
Copy link
Author

@edwardhorsford Yes good point.

@tvararu
Copy link
Contributor

tvararu commented Jul 7, 2017

@carolinegreen can you update this with an end-to-end test?

You'll need to two new blocks for autoselect-related tests, and write a test in each: one for if the hint is actually being displayed in the first place using the autoselect: true example, and then one if it doesn't get displayed when the displayHint: false option is set on the other example.

@tvararu tvararu temporarily deployed to accessible-autocomplete-pr-186 July 10, 2017 16:13 Inactive
Caroline Green added 4 commits July 10, 2017 17:14
@tvararu tvararu temporarily deployed to accessible-autocomplete-pr-186 July 10, 2017 16:17 Inactive
@tvararu
Copy link
Contributor

tvararu commented Jul 11, 2017

The tests are failing because IE9 doesn't have pointer events; we need to wrap the tests to not run on isIE9 (the variable is already declared but commented at the top of the tests).

@tvararu tvararu temporarily deployed to accessible-autocomplete-pr-186 July 14, 2017 15:39 Inactive
IE9 doesn't get a hint because it doesn't support pointer events.
@tlwr
Copy link

tlwr commented Jun 4, 2019

I'm closing this PR as it has been open for a considerable amount of time and we're trying to cut down the number of orphaned PRs in alphagov.

@tlwr tlwr closed this Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to disable <Hint />
4 participants