Add date validation for TimePeriodDateRange start/end fields

Include DateValidation concern to handle invalid multiparameter date
assignment (e.g. month=23) gracefully with validation errors instead
of raising ActiveRecord::MultiparameterAssignmentErrors.

Author: edavey

app/models/block/time_period_date_range.rb

@@ -2,6 +2,9 @@ module Block
   class TimePeriodDateRange < ApplicationRecord
     self.table_name = "block_time_period_date_ranges"
 
+    include DateValidation
+    date_attributes :start, :end
+
     belongs_to :edition, class_name: "Block::TimePeriodEdition"
 
     validates :start, presence: true

config/locales/en.yml

@@ -42,6 +42,14 @@ en:
               alphanumeric: "must contain at least one letter or number"
             lead_organisation_id:
               blank: "cannot be blank"
+        block/time_period_date_range:
+          attributes:
+            start:
+              blank: "Enter a start date"
+              invalid_date: "Start date is not a valid date"
+            end:
+              blank: "Enter an end date"
+              invalid_date: "End date is not a valid date"
     attributes:
       edition/document:
         title:

features/block/time_period/create_block.feature

@@ -17,4 +17,11 @@ Feature: Create "Time period" content block (Block architecture)
 
   Scenario: Editor must supply valid edition details
     When I submit the new-style time period form incorrectly
-    Then I see the errors messages describing the problems with the new-style edition
+    Then I see the errors messages describing the problems with the new-style edition
+
+  Scenario: Editor must supply valid date range dates
+    When I fill the new-style time period form correctly
+    And I proceed to add a date range for the new-style Time period
+    And I supply an invalid date for the date range
+    And I save and continue
+    Then I see the error message for the invalid date

features/step_definitions/block/time_period_steps.rb

@@ -59,3 +59,23 @@
     ).render,
   )
 end
+
+When("I supply an invalid date for the date range") do
+  # Start date with invalid month (23)
+  fill_in "edition[date_range_attributes][start(3i)]", with: "6"
+  fill_in "edition[date_range_attributes][start(2i)]", with: "23"
+  fill_in "edition[date_range_attributes][start(1i)]", with: "2025"
+  select "09", from: "start_hour"
+  select "00", from: "start_minute"
+
+  # Valid end date
+  fill_in "edition[date_range_attributes][end(3i)]", with: "5"
+  fill_in "edition[date_range_attributes][end(2i)]", with: "4"
+  fill_in "edition[date_range_attributes][end(1i)]", with: "2026"
+  select "17", from: "end_hour"
+  select "30", from: "end_minute"
+end
+
+Then("I see the error message for the invalid date") do
+  expect(page).to have_content("Start date is not a valid date")
+end

spec/unit/app/models/block/time_period_date_range_spec.rb

@@ -11,6 +11,28 @@
     it { is_expected.to validate_presence_of(:start) }
     it { is_expected.to validate_presence_of(:end) }
 
+    describe "invalid date validation" do
+      it "is invalid when start date has invalid month" do
+        date_range = described_class.new(edition: edition)
+        # Simulate multiparameter assignment with invalid month (23)
+        date_range.start = { 1 => 2025, 2 => 23, 3 => 6, 4 => 0, 5 => 0 }
+        date_range.end = Time.zone.parse("2026-04-05 23:59")
+
+        expect(date_range).not_to be_valid
+        expect(date_range.errors[:start]).to include("Start date is not a valid date")
+      end
+
+      it "is invalid when end date has invalid day" do
+        date_range = described_class.new(edition: edition)
+        date_range.start = Time.zone.parse("2025-04-06 00:00")
+        # Simulate multiparameter assignment with invalid day (32)
+        date_range.end = { 1 => 2025, 2 => 4, 3 => 32, 4 => 23, 5 => 59 }
+
+        expect(date_range).not_to be_valid
+        expect(date_range.errors[:end]).to include("End date is not a valid date")
+      end
+    end
+
     describe "end_date_after_start_date" do
       it "is invalid when end is before start" do
         date_range = described_class.new(