Run markdown render in spec/rails_helper

Run the markdown render for feature tests in spec/rails_helper. This is because
feature tests require the app/views/generated views to exist

Author: Obsiye

lib/tasks/markdown_to_static_html.rake

@@ -4,8 +4,6 @@ def format_date(date)
   return nil if date.blank?
 
   Date.iso8601(date).strftime("%-d/%-m/%Y")
-rescue ArgumentError, TypeError
-  nil
 end
 
 def process_visualisation_data(chart_json)
@@ -99,7 +97,9 @@ namespace :markdown do
 
       FileUtils.mkdir_p(output_path.dirname)
 
-      puts("Rendering #{path.basename} to => #{output_path}")
+      unless Rails.env.test?
+        puts("Rendering #{path.basename} to => #{output_path}")
+      end
 
       html = ApplicationController.renderer.render(
         partial: "v2/collection/content",

spec/features/v2/charts_spec.rb

@@ -1,18 +1,7 @@
 require "rails_helper"
 
 RSpec.describe "Charts", type: :system, js: true do
-  before(:all) do
-    Rake.application.rake_require("tasks/markdown_to_static_html")
-    Rake::Task.define_task(:environment)
-    Rails.configuration.x.markdown_collections_output_location = "app/views/generated/collections"
-    Rails.configuration.x.markdown_collections_location_glob = "app/content/collections/**/*.md"
-    Rails.configuration.x.visualisations_data_location = "app/content/data"
-    Rake::Task["markdown:render"].invoke
-  end
-
-  after(:all) do
-    FileUtils.rm_rf("app/views/generated")
-  end
+  # Setup and teardown for generated views is handled globally in rails_helper.rb
 
   scenario "I can see a single series line chart on a collection page" do
     given_i_visit_a_collection_page_with_a_single_series_line_chart

spec/features/v2/collections_spec.rb

@@ -1,18 +1,7 @@
 require "rails_helper"
 
 RSpec.feature "collections", type: :feature do
-  before(:all) do
-    Rake.application.rake_require("tasks/markdown_to_static_html")
-    Rake::Task.define_task(:environment)
-    Rails.configuration.x.markdown_collections_output_location = "app/views/generated/collections"
-    Rails.configuration.x.markdown_collections_location_glob = "app/content/collections/**/*.md"
-    Rails.configuration.x.visualisations_data_location = "app/content/data"
-    Rake::Task["markdown:render"].invoke
-  end
-
-  after(:all) do
-    FileUtils.rm_rf("app/views/generated")
-  end
+  # Setup and teardown for generated views is handled globally in rails_helper.rb
 
   scenario "I visit a collection page" do
     given_i_am_on_a_collection_page

spec/rails_helper.rb

@@ -68,6 +68,22 @@
   config.include FactoryBot::Syntax::Methods
 end
 
+RSpec.configure do |config|
+  config.before(:suite) do
+    Rake.application.rake_require("tasks/markdown_to_static_html")
+    Rake::Task.define_task(:environment)
+    Rails.configuration.x.markdown_collections_output_location = "app/views/generated/collections"
+    Rails.configuration.x.markdown_collections_location_glob = "app/content/collections/**/*.md"
+    Rails.configuration.x.visualisations_data_location = "app/content/data"
+    Rake::Task["markdown:render"].reenable
+    Rake::Task["markdown:render"].invoke
+  end
+
+  config.after(:suite) do
+    FileUtils.rm_rf("app/views/generated")
+  end
+end
+
 # Setup chrome headless driver
 GovukTest.configure