Merge pull request #622 from alphagov/deploy-after-archiving

Refactoring for re-opening

Author: pixeltrix

Gemfile

@@ -5,10 +5,6 @@ gem 'dotenv-rails', :require => 'dotenv/rails-now'
 
 gem 'rails', '4.2.8'
 
-# Legacy Rails feature gems - will no longer be supported in Rails 5.0
-gem 'responders'
-gem 'rails_autolink'
-
 gem 'rake'
 gem 'pg'
 gem 'authlogic'

Gemfile.lock

@@ -226,17 +226,13 @@ GEM
       rails-deprecated_sanitizer (>= 1.0.1)
     rails-html-sanitizer (1.0.3)
       loofah (~> 2.0)
-    rails_autolink (1.1.6)
-      rails (> 3.1)
     railties (4.2.8)
       actionpack (= 4.2.8)
       activesupport (= 4.2.8)
       rake (>= 0.8.7)
       thor (>= 0.18.1, < 2.0)
     rake (12.0.0)
     request_store (1.2.1)
-    responders (2.1.0)
-      railties (>= 4.2.0, < 5)
     rspec-core (3.4.4)
       rspec-support (~> 3.4.0)
     rspec-expectations (3.4.0)
@@ -341,9 +337,7 @@ DEPENDENCIES
   pry
   puma
   rails (= 4.2.8)
-  rails_autolink
   rake
-  responders
   rspec-rails
   sass-rails (~> 5.0)
   shoulda-matchers

app/controllers/admin/debate_outcomes_controller.rb

@@ -1,5 +1,4 @@
 class Admin::DebateOutcomesController < Admin::AdminController
-  respond_to :html
   before_action :fetch_petition
   before_action :fetch_debate_outcome
 

app/controllers/admin/government_response_controller.rb

@@ -1,5 +1,4 @@
 class Admin::GovernmentResponseController < Admin::AdminController
-  respond_to :html
   before_action :fetch_petition
   before_action :fetch_government_response
 

app/controllers/admin/moderation_controller.rb

@@ -1,5 +1,4 @@
 class Admin::ModerationController < Admin::AdminController
-  respond_to :html
   before_action :fetch_petition
 
   def update

app/controllers/admin/notes_controller.rb

@@ -1,5 +1,4 @@
 class Admin::NotesController < Admin::AdminController
-  respond_to :html
   before_action :fetch_petition
   before_action :fetch_note
 

app/controllers/admin/parliaments_controller.rb

@@ -1,6 +1,4 @@
 class Admin::ParliamentsController < Admin::AdminController
-  respond_to :html
-
   before_action :require_sysadmin
   before_action :fetch_parliament
 

app/controllers/admin/petition_details_controller.rb

@@ -1,5 +1,4 @@
 class Admin::PetitionDetailsController < Admin::AdminController
-  respond_to :html
   before_action :fetch_petition
 
   def show
@@ -22,7 +21,7 @@ def fetch_petition
   def petition_params
     params.require(:petition).permit(
       :action, :background, :additional_details,
-      :special_consideration, :creator_signature_attributes => [:name]
+      :special_consideration, :creator_attributes => [:name]
     )
   end
 end

app/controllers/admin/petition_emails_controller.rb

@@ -1,5 +1,4 @@
 class Admin::PetitionEmailsController < Admin::AdminController
-  respond_to :html
   before_action :fetch_petition
   before_action :build_email, only: [:new, :create]
   before_action :fetch_email, only: [:edit, :update, :destroy]

app/controllers/admin/petition_tags_controller.rb

@@ -1,5 +1,4 @@
 class Admin::PetitionTagsController < Admin::AdminController
-  respond_to :html
   before_action :fetch_petition
 
   def show