Merge pull request #349 from alphagov/restrict-government-response-summary-length

Add javascript counter to government response summary

Author: alanth

app/assets/javascripts/create-petition.js …/assets/javascripts/character-counter.jsapp/assets/javascripts/create-petition.js renamed to app/assets/javascripts/character-counter.js app/assets/javascripts/create-petition.js renamed to app/assets/javascripts/character-counter.js

@@ -2,7 +2,7 @@ class GovernmentResponse < ActiveRecord::Base
   belongs_to :petition, touch: true
 
   validates :petition, presence: true
-  validates :summary, presence: true, length: { maximum: 500 }
+  validates :summary, presence: true, length: { maximum: 200 }
   validates :details, length: { maximum: 4000 }, allow_blank: true
 
   after_create do

app/models/government_response.rb

@@ -3,7 +3,8 @@
   <%= form_row :for => [f.object, :summary] do %>
     <%= f.label :summary, 'Summary quote', class: 'form-label' %>
     <%= error_messages_for_field f.object, :summary %>
-    <%= f.text_area :summary, rows: 3, cols: 70, tabindex: increment, class: 'form-control' %>
+    <%= f.text_area :summary, rows: 3, cols: 70, tabindex: increment, 'data-max-length': 200, class: 'form-control' %>
+    <p class="character-count">200 characters max</p>
   <% end %>
 
   <%= form_row :for => [f.object, :details] do %>
@@ -14,3 +15,5 @@
 
   <%= email_signatures_with_count_submit_button(f, petition) %>
 <% end -%>
+
+<%= javascript_include_tag 'character-counter' %>

app/views/admin/government_response/_petition_action_government_response.html.erb

@@ -37,7 +37,7 @@
       <%= render 'application/footer' %>
       <%= javascript_include_tag 'application' %>
       <% if create_petition_page? %>
-        <%= javascript_include_tag 'create-petition' %>
+        <%= javascript_include_tag 'character-counter' %>
       <% end %>
     <% end %>
   </body>

app/views/layouts/application.html.erb

@@ -15,7 +15,7 @@
   delayed/web/application.css
   ie.js
   admin.js
-  create-petition.js
+  character-counter.js
 )
 
 # Compress JavaScript assets.

config/initializers/assets.rb

@@ -18,7 +18,7 @@
 
     it { is_expected.to validate_presence_of(:petition) }
     it { is_expected.to validate_presence_of(:summary) }
-    it { is_expected.to validate_length_of(:summary).is_at_most(500) }
+    it { is_expected.to validate_length_of(:summary).is_at_most(200) }
     it { is_expected.to validate_length_of(:details).is_at_most(4000) }
   end