Merge pull request #506 from alphagov/fix-record-not-unique-errors

Fix ActiveRecord::RecordNotUnique errors

Author: h-lame

app/controllers/signatures_controller.rb

@@ -149,6 +149,8 @@ def handle_new_signature(petition)
         format.html { render :new }
       end
     end
+  rescue ActiveRecord::RecordNotUnique => e
+    redirect_to thank_you_petition_signatures_url(petition)
   end
 
   def validate_sponsor

spec/controllers/signatures_controller_spec.rb

@@ -430,6 +430,19 @@ def do_post(options = {})
           expect(response).to render_template(:new)
         end
       end
+
+      context "when a race condition occurs" do
+        let(:exception) { ActiveRecord::RecordNotUnique.new("PG::UniqueViolation") }
+        before do
+          FactoryGirl.create(:validated_signature, signature_params.merge(petition_id: petition.id))
+          allow_any_instance_of(Signature).to receive(:save).and_raise(exception)
+        end
+
+        it "redirects to the thank you page" do
+          do_post(stage: 'done')
+          expect(response).to redirect_to("https://petition.parliament.uk/petitions/#{petition.id}/signatures/thank-you")
+        end
+      end
     end
 
     context "when the petition is closed" do