Merge pull request #641 from alphagov/add-christmas-delay-message

Add message about moderation delayed over Christmas

Author: pixeltrix

app/helpers/date_time_helper.rb

@@ -57,4 +57,14 @@ def scheduled_for_debate_in_words(date, today = Date.current)
 
     t(key, scope: scope, formatted_date: short_date_format(date))
   end
+
+  def christmas_period?(today = Date.current)
+    if today.mon == 12
+      today.day > 21 ? true : false
+    elsif today.mon == 1
+      today.day < 5 ? true : false
+    else
+      false
+    end
+  end
 end

app/views/sponsor_mailer/sponsor_signed_email_on_threshold.html.erb

@@ -4,7 +4,11 @@
 
 <p><%= @sponsor.name %> supported your petition – “<%= @petition.action %>”.</p>
 
+<% if christmas_period? %>
+<p><%= @sponsor_count %> people have supported your petition so far. We’re checking your petition to make sure it meets the petition standards. If it does, we’ll publish it. This usually takes a week or less but over the Christmas period it may take us a little longer than usual. We’ll check your petition as quickly as we can.</p>
+<% else %>
 <p><%= @sponsor_count %> people have supported your petition so far. We’re checking your petition to make sure it meets the petition standards. If it does, we’ll publish it. This usually takes a week or less.</p>
+<% end %>
 
 <p>Find out how we check petitions before we publish them:<br />
 <%= link_to nil, help_url(anchor: 'standards') %></p>

app/views/sponsor_mailer/sponsor_signed_email_on_threshold.text.erb

@@ -4,7 +4,11 @@ Your petition is nearly ready to go.
 
 <%= @sponsor.name %> supported your petition – "<%= @petition.action %>".
 
+<% if christmas_period? %>
+<%= @sponsor_count %> people have supported your petition so far. We’re checking your petition to make sure it meets the petition standards. If it does, we’ll publish it. This usually takes a week or less but over the Christmas period it may take us a little longer than usual. We’ll check your petition as quickly as we can.
+<% else %>
 <%= @sponsor_count %> people have supported your petition so far. We’re checking your petition to make sure it meets the petition standards. If it does, we’ll publish it. This usually takes a week or less.
+<% end %>
 
 Find out how we check petitions before we publish them:
 <%= help_url(anchor: 'standards') %>

spec/helpers/date_time_helper_spec.rb

@@ -134,4 +134,56 @@
       end
     end
   end
+
+  describe "#christmas_period?" do
+    context "when the date is before the 22nd Dec" do
+      around do |example|
+        travel_to("2017-12-21") { example.run }
+      end
+
+      it "returns false" do
+        expect(helper.christmas_period?).to eq(false)
+      end
+    end
+
+    context "when the date is the 22nd Dec" do
+      around do |example|
+        travel_to("2017-12-22") { example.run }
+      end
+
+      it "returns true" do
+        expect(helper.christmas_period?).to eq(true)
+      end
+    end
+
+    context "when the date is between 22nd Dec and 4th Jan" do
+      around do |example|
+        travel_to("2017-12-26") { example.run }
+      end
+
+      it "returns true" do
+        expect(helper.christmas_period?).to eq(true)
+      end
+    end
+
+    context "when the date is the 4th Jan" do
+      around do |example|
+        travel_to("2018-01-04") { example.run }
+      end
+
+      it "returns true" do
+        expect(helper.christmas_period?).to eq(true)
+      end
+    end
+
+    context "when the date is after the 4th Jan" do
+      around do |example|
+        travel_to("2018-01-05") { example.run }
+      end
+
+      it "returns false" do
+        expect(helper.christmas_period?).to eq(false)
+      end
+    end
+  end
 end

spec/mailers/previews/sponsor_mailer_preview.rb

@@ -1,6 +1,13 @@
 # Preview all emails at http://localhost:3000/rails/mailers/sponsor_mailer
 class SponsorMailerPreview < ActionMailer::Preview
-  def new_sponsor_email
-    SponsorMailer.new_sponsor_email(Sponsor.first)
+  def petition_and_email_confirmation_for_sponsor
+    SponsorMailer.petition_and_email_confirmation_for_sponsor(Signature.sponsors.last)
+  end
+
+  def sponsor_signed_email_on_threshold
+    sponsor = Signature.sponsors.last
+    petition = sponsor.petition
+
+    SponsorMailer.sponsor_signed_email_on_threshold(petition, sponsor)
   end
 end

spec/mailers/sponsor_mailer_spec.rb

@@ -15,7 +15,7 @@
   end
 
   let :sponsor do
-    FactoryBot.create(:sponsor, :pending, email: 'allyadams@outlook.com', petition: petition)
+    FactoryBot.create(:sponsor, :pending, name: "Ally Adams", email: 'allyadams@outlook.com', petition: petition)
   end
 
   describe "#petition_and_email_confirmation_for_sponsor" do
@@ -75,4 +75,88 @@
       end
     end
   end
+
+  describe "#sponsor_signed_email_on_threshold" do
+    subject(:mail) { described_class.sponsor_signed_email_on_threshold(petition, sponsor) }
+
+    before do
+      allow(petition).to receive_message_chain(:sponsors, :validated, :count).and_return(5)
+    end
+
+    shared_examples_for "a sponsor signed on threshold email" do
+      it "has the correct subject" do
+        expect(mail.subject).to eq("We’re checking your petition")
+      end
+
+      it "sends it only to the creator" do
+        expect(mail.to).to eq(%w[bazbutler@gmail.com])
+        expect(mail.cc).to be_blank
+        expect(mail.bcc).to be_blank
+      end
+
+      it "includes the creator's name in the body" do
+        expect(mail).to have_body_text(%r[Barry Butler])
+      end
+
+      it "includes the sponsor's name in the body" do
+        expect(mail).to have_body_text(%r[Ally Adams])
+      end
+
+      it "includes the petition action" do
+        expect(mail).to have_body_text(%r[Allow organic vegetable vans to use red diesel])
+      end
+
+      it "doesn't include the petition background" do
+        expect(mail).not_to have_body_text(%r[Add vans to permitted users of red diesel])
+      end
+
+      it "doesn't include the petition additional details" do
+        expect(mail).not_to have_body_text(%r[To promote organic vegetables])
+      end
+
+      it "includes the sponsor count" do
+        expect(mail).to have_body_text(%r[5 people have supported your petition so far])
+      end
+
+      it "tells the creator that the petition is being checked" do
+        expect(mail).to have_body_text(%r[We’re checking your petition to make sure it meets the petition standards])
+      end
+    end
+
+    context "before the Christmas period" do
+      around do |example|
+        travel_to("2017-12-21") { example.run }
+      end
+
+      it_behaves_like "a sponsor signed on threshold email"
+
+      it "doesn't include the moderation delay message" do
+        expect(mail).not_to have_body_text(%r[over the Christmas period it may take us a little longer than usual])
+      end
+    end
+
+    context "during the Christmas period" do
+      around do |example|
+        travel_to("2017-12-26") { example.run }
+      end
+
+      it_behaves_like "a sponsor signed on threshold email"
+
+      it "includes the moderation delay message" do
+        expect(mail).to have_body_text(%r[over the Christmas period it may take us a little longer than usual])
+      end
+    end
+
+    context "after the Christmas period" do
+      around do |example|
+        travel_to("2018-01-05") { example.run }
+      end
+
+      it_behaves_like "a sponsor signed on threshold email"
+
+      it "doesn't include the moderation delay message" do
+        expect(mail).not_to have_body_text(%r[over the Christmas period it may take us a little longer than usual])
+      end
+    end
+  end
 end