Merge pull request #665 from alphagov/sanitize-postcode-dashes

Strip hyphens and en/em dashes from the postcode before validating

Author: pixeltrix

lib/postcode_sanitizer.rb

@@ -1,5 +1,5 @@
 module PostcodeSanitizer
   def self.call(postcode)
-    postcode.to_s.gsub(/\s+/, "").upcase
+    postcode.to_s.gsub(/\s+|-+|–+|—+/, "").upcase
   end
 end

spec/lib/postcode_sanitizer_spec.rb

@@ -2,18 +2,29 @@
 require 'postcode_sanitizer'
 
 RSpec.describe PostcodeSanitizer do
-  describe '.call' do
+  describe ".call" do
     it "removes all whitespace" do
-      postcode = " N1  1TY  "
-      expect(described_class.call(postcode)).to eq "N11TY"
+      expect(described_class.call(" N1  1TY  ")).to eq "N11TY"
     end
+
     it "upcases the postcode" do
-      postcode = "n11ty "
-      expect(described_class.call(postcode)).to eq "N11TY"
+      expect(described_class.call("n11ty ")).to eq "N11TY"
     end
+
     it "removes whitespaces and upcase the postcode" do
-      postcode = "   N1  1ty "
-      expect(described_class.call(postcode)).to eq "N11TY"
+      expect(described_class.call("   N1  1ty ")).to eq "N11TY"
+    end
+
+    it "removes hypens and upcases the postcode" do
+      expect(described_class.call("   N1-1ty ")).to eq "N11TY"
+    end
+
+    it "removes en dashes and upcases the postcode" do
+      expect(described_class.call("   N1–1ty ")).to eq "N11TY"
+    end
+
+    it "removes em dashes and upcases the postcode" do
+      expect(described_class.call("   N1—1ty ")).to eq "N11TY"
     end
   end
 end