Merge pull request #960 from alphagov/remove-contrived-primary-topic-from-rake-task

[CHAT-388] Remove contrived primary topic from topics rake task

Author: davidgisbey

lib/tasks/evaluation.rake

@@ -105,16 +105,6 @@ namespace :evaluation do
     raise "Requires an INPUT env var" if ENV["INPUT"].blank?
 
     result = AutoEvaluation::TopicTagger.call(ENV["INPUT"])
-
-    # This is a temporary solution to ensure that the evaluation repo topic tagger evaluations continue to work
-    # since primary_topic is a required field on the GenerateInput class. This will be addressed in a follow up bit
-    # of work.
-    if result.status == "error"
-      result = result.to_h.merge(
-        primary_topic: "invalid_tool_output",
-      )
-    end
-
     puts(result.to_json)
   end
 

spec/lib/tasks/evaluation_spec.rb

@@ -431,37 +431,6 @@
           .to output("#{result.to_json}\n").to_stdout
       end
     end
-
-    context "when the result has an error status" do
-      it "sets the primary_topic to 'invalid_tool_output'" do
-        ClimateControl.modify(INPUT: input) do
-          allow(AutoEvaluation::TopicTagger).to receive(:call)
-                                            .with(input)
-                                            .and_return(
-                                              AutoEvaluation::TopicTagger::Result.new(
-                                                status: "error",
-                                                primary_topic: nil,
-                                                secondary_topic: nil,
-                                                metrics: {},
-                                                llm_response: {},
-                                                error_message: "LLM did not return valid JSON that conformed to the schema.",
-                                              ),
-                                            )
-
-          expected_result = {
-            status: "error",
-            primary_topic: "invalid_tool_output",
-            secondary_topic: nil,
-            metrics: {},
-            llm_response: {},
-            error_message: "LLM did not return valid JSON that conformed to the schema.",
-          }.to_json
-
-          expect { Rake::Task[task_name].invoke }
-            .to output("#{expected_result}\n").to_stdout
-        end
-      end
-    end
   end
 
   describe "batch_process" do