Skip to content

Commit 285ec72

Browse files
committed
Remove answer feedback model and table
This commit completes the removal of Useful/Not useful answer feedback. It removes AnswerFeedback and its creation form, removes the answer association and related eager loading, cleans up factories and specs, and adds a migration to drop the answer_feedback table.
1 parent 0ab97b9 commit 285ec72

13 files changed

Lines changed: 19 additions & 127 deletions

app/controllers/conversations_controller.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ def update
4242

4343
def answer
4444
@question = Question.where(conversation: @conversation)
45-
.includes(answer: [{ sources: :chunk }, :feedback])
45+
.includes(answer: { sources: :chunk })
4646
.find(params[:question_id])
4747
answer = @question.check_or_create_timeout_answer
4848

app/models/answer.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ def self.response_for_question_routing_label(label)
5555

5656
belongs_to :question
5757
has_many :sources, -> { order(relevancy: :asc) }, class_name: "AnswerSource"
58-
has_one :feedback, class_name: "AnswerFeedback"
5958
has_one :topics, class_name: "AnswerAnalysis::Topics"
6059
has_many :answer_relevancy_runs,
6160
-> { order(:created_at) },

app/models/answer_feedback.rb

Lines changed: 0 additions & 17 deletions
This file was deleted.

app/models/conversation.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ def self.hashed_end_user_id(end_user_id)
2424

2525
def questions_for_showing_conversation(only_answered: false, before_id: nil, after_id: nil, limit: nil)
2626
scope = Question.where(conversation: self)
27-
.includes(answer: [{ sources: :chunk }, :feedback])
27+
.includes(answer: { sources: :chunk })
2828
.active
2929
scope = scope.joins(:answer) if only_answered
3030

app/models/form/create_answer_feedback.rb

Lines changed: 0 additions & 21 deletions
This file was deleted.

app/models/question.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ def check_or_create_timeout_answer
5151
create_answer(
5252
message: Answer::CannedResponses::TIMED_OUT_RESPONSE,
5353
status: :error_timeout,
54-
feedback: nil,
5554
)
5655
end
5756
end
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
class DropAnswerFeedback < ActiveRecord::Migration[8.0]
2+
def up
3+
drop_table :answer_feedback
4+
end
5+
6+
def down
7+
create_table :answer_feedback, id: :uuid do |t|
8+
t.references :answer, type: :uuid, null: false, index: { unique: true }, foreign_key: { on_delete: :cascade }
9+
t.boolean :useful, null: false
10+
11+
t.timestamps
12+
end
13+
14+
add_index :answer_feedback, :created_at
15+
end
16+
end

db/schema.rb

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
#
1111
# It's strongly recommended that you check this file into your version control system.
1212

13-
ActiveRecord::Schema[8.1].define(version: 2026_04_17_081153) do
13+
ActiveRecord::Schema[8.1].define(version: 2026_04_27_093000) do
1414
# These are extensions that must be enabled in order to support this database
1515
enable_extension "citext"
1616
enable_extension "pg_catalog.plpgsql"
@@ -91,15 +91,6 @@
9191
t.index ["answer_id"], name: "index_answer_analysis_topics_on_answer_id", unique: true
9292
end
9393

94-
create_table "answer_feedback", id: :uuid, default: -> { "gen_random_uuid()" }, force: :cascade do |t|
95-
t.uuid "answer_id", null: false
96-
t.datetime "created_at", null: false
97-
t.datetime "updated_at", null: false
98-
t.boolean "useful", null: false
99-
t.index ["answer_id"], name: "index_answer_feedback_on_answer_id", unique: true
100-
t.index ["created_at"], name: "index_answer_feedback_on_created_at"
101-
end
102-
10394
create_table "answer_source_chunks", id: :uuid, default: -> { "gen_random_uuid()" }, force: :cascade do |t|
10495
t.string "base_path", null: false
10596
t.integer "chunk_index", null: false
@@ -232,7 +223,6 @@
232223
add_foreign_key "answer_analysis_context_relevancy_runs", "answers", on_delete: :cascade
233224
add_foreign_key "answer_analysis_faithfulness_runs", "answers", on_delete: :cascade
234225
add_foreign_key "answer_analysis_topics", "answers", on_delete: :cascade
235-
add_foreign_key "answer_feedback", "answers", on_delete: :cascade
236226
add_foreign_key "answer_sources", "answer_source_chunks", on_delete: :restrict
237227
add_foreign_key "answer_sources", "answers", on_delete: :cascade
238228
add_foreign_key "answers", "questions", on_delete: :cascade

spec/factories/answer_factory.rb

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
status { :answered }
66
completeness { :complete }
77
sources { [] }
8-
feedback { nil }
98
topics { nil }
109

1110
trait :with_sources do
@@ -25,10 +24,6 @@
2524
end
2625
end
2726

28-
trait :with_feedback do
29-
feedback { build(:answer_feedback) }
30-
end
31-
3227
trait :with_topics do
3328
topics { build(:answer_analysis_topics) }
3429
end

spec/factories/answer_feedback_factory.rb

Lines changed: 0 additions & 6 deletions
This file was deleted.

0 commit comments

Comments
 (0)