Scope signon user filter to convos created via API

Now we've got the concept of a source for a conversation, we can ensure
that we signon user filter only returns conversations created via the API.

I've also updated the question show page to only show the signon user row
which links to the index page with the user filter when the source is
API.

Author: davidgisbey

app/helpers/admin/questions_helper.rb

@@ -85,7 +85,7 @@ def question_show_summary_list_rows(question, answer, question_number, total_que
       end
 
       signon_user = conversation.signon_user
-      if signon_user.present?
+      if signon_user.present? && conversation.source_api?
         rows << {
           field: "API user",
           value: safe_join([

app/models/admin/filters/questions_filter.rb

@@ -134,7 +134,7 @@ def user_scope(scope)
   def signon_user_scope(scope)
     return scope if signon_user_id.blank? || user_id.present?
 
-    scope.joins(:conversation).where(conversation: { signon_user_id: signon_user_id })
+    scope.joins(:conversation).where(conversation: { signon_user_id: signon_user_id, source: :api })
   end
 
   def question_routing_label_scope(scope)

spec/helpers/admin/questions_helper_spec.rb

@@ -178,7 +178,7 @@
 
     it "returns a row with a link to filter the questions table by the signon user" do
       signon_user = create(:signon_user)
-      conversation.update!(signon_user:)
+      conversation.update!(signon_user:, source: :api)
       result = helper.question_show_summary_list_rows(question, nil, 1, 1)
 
       row = result.find { |r| r[:field] == "API user" }
@@ -202,6 +202,14 @@
       row = result.find { |r| r[:field] == "Source" }
       expect(row[:value]).to eq("API")
     end
+
+    it "doesn't return a signon user row if the conversation wasn't created via the API" do
+      signon_user = create(:signon_user)
+      conversation.update!(signon_user:)
+
+      result = helper.question_show_summary_list_rows(question, nil, 1, 1)
+      expect(returned_keys(result)).not_to include("API user")
+    end
   end
 
   describe "#decode_and_mark_unicode_tag_segments" do

spec/models/admin/filters/questions_filter_spec.rb

@@ -234,8 +234,8 @@
     it "filters the results by signon user" do
       alice = create(:signon_user, email: "alice@example.com")
       bob = create(:signon_user, email: "bob@example.com")
-      alice_question = create(:question, conversation: create(:conversation, signon_user: alice))
-      bob_question = create(:question, conversation: create(:conversation, signon_user: bob))
+      alice_question = create(:question, conversation: create(:conversation, :api, signon_user: alice))
+      bob_question = create(:question, conversation: create(:conversation, :api, signon_user: bob))
 
       filter = described_class.new(signon_user_id: alice.id)
       expect(filter.results).to eq([alice_question])
@@ -244,6 +244,15 @@
       expect(filter.results).to eq([bob_question])
     end
 
+    it "filters out results assoicated with a signon user that weren't created via the API" do
+      signon_user = create(:signon_user)
+      create(:question, conversation: create(:conversation, signon_user:))
+
+      filter = described_class.new(signon_user_id: signon_user.id)
+
+      expect(filter.results).to eq([])
+    end
+
     it "doesn't filter the results by signon user if signon_user_id and user_id are passed in" do
       alice = create(:signon_user, email: "alice@example.com")
       bob = create(:early_access_user, email: "bob@example.com")

spec/system/admin/user_filters_questions_spec.rb

@@ -107,8 +107,8 @@ def and_there_are_questions_associated_with_users
   end
 
   def and_there_are_questions_associated_with_signon_users
-    @conversation1 = build(:conversation, signon_user: @signon_user)
-    conversation2 = build(:conversation, signon_user: @signon_user)
+    @conversation1 = build(:conversation, :api, signon_user: @signon_user)
+    conversation2 = build(:conversation, :api, signon_user: @signon_user)
     create(:question, conversation: @conversation1, message: "Hello world")
     create(:question, conversation: conversation2, message: "Greetings world")