Add shared example for OpenAPI spec adherence

Honestly, i'm not sure if this is better than just having separate tests
due to the extensive setup required in the before block. It might be that
there's a better way to test this.

Would def be good to get some feedback.

Author: davidgisbey

spec/requests/api/v0/conversations_spec.rb

@@ -19,12 +19,40 @@
     end
   end
 
+  shared_examples "OpenAPI-compliant endpoint" do |path, method, field|
+    let(:route_params) { {} }
+
+    context "when the response returned does not conform to the OpenAPI specification" do
+      it "raises an error and returns the invalid params in the error message for #{path}" do
+        expect { process(method.to_sym, public_send(path.to_sym, *route_params)) }
+          .to raise_error(Committee::InvalidResponse) do |error|
+            expect(error.message).to match(/missing required parameters: #{field}/)
+          end
+      end
+    end
+  end
+
+
   describe "GET :answer" do
     it_behaves_like "responds with forbidden if user doesn't have conversation-api permission",
                     :api_v0_answer_question_path,
                     :get do
                       let(:route_params) { [create(:conversation), create(:question)] }
                     end
+    it_behaves_like "OpenAPI-compliant endpoint",
+                    :api_v0_answer_question_path,
+                    :get,
+                    :created_at do
+                      let(:question) { create(:question, :with_answer, conversation:) }
+                      let(:route_params) { [conversation, question] }
+
+                      before do
+                        eager_loaded_answer = Answer.includes(:sources, :feedback).find(question.answer.id)
+                        answer_blueprint = AnswerBlueprint.render_as_hash(eager_loaded_answer)
+                        answer_blueprint.delete(:created_at)
+                        allow(AnswerBlueprint).to receive(:render).and_return(answer_blueprint)
+                      end
+                    end
 
     context "when an answer has been generated for the question" do
       let!(:answer) { create(:answer, question:) }
@@ -63,21 +91,6 @@
         expect(JSON.parse(response.body)).to eq({})
       end
     end
-
-    context "when the response returned does not conform to the OpenAPI specification" do
-      it "raises an error and returns the invalid params in the error message" do
-        answer = create(:answer, question:)
-        eager_loaded_answer = Answer.includes(:sources, :feedback).find(answer.id)
-        answer_blueprint = AnswerBlueprint.render_as_hash(eager_loaded_answer)
-        answer_blueprint.delete(:created_at)
-        allow(AnswerBlueprint).to receive(:render).and_return(answer_blueprint)
-
-        expect { get api_v0_answer_question_path(conversation, question) }
-          .to raise_error(Committee::InvalidResponse) do |error|
-            expect(error.message).to match(/missing required parameters: created_at/)
-          end
-      end
-    end
   end
 
   describe "POST :answer_feedback" do
@@ -87,6 +100,21 @@
       let(:route_params) { [create(:conversation), create(:answer)] }
     end
 
+    it_behaves_like "OpenAPI-compliant endpoint",
+                    :api_v0_answer_feedback_path,
+                    :post,
+                    :fields do
+                      let(:answer) { create(:answer) }
+                      let(:route_params) { [answer.question.conversation, answer] }
+
+                      before do
+                        answer = create(:answer, question:)
+                        error_blueprint = ValidationErrorBlueprint.render_as_hash(message: "Could not save answer feedback")
+                        error_blueprint.delete(:fields)
+                        allow(ValidationErrorBlueprint).to receive(:render).and_return(error_blueprint.as_json)
+                      end
+                    end
+
     context "when the params are valid" do
       context "and the answer has no feedback" do
         let!(:answer) { create(:answer, question:) }