Add shared example for retries on service errors

There's essentially duplicate tests for retries in the topics and relevancy
job specs. This adds a shared example we can reuse across all the metric
specs.

Author: davidgisbey

spec/jobs/answer_analysis/answer_relevancy_job_spec.rb

@@ -18,6 +18,13 @@
 
   it_behaves_like "a job in queue", "default"
   it_behaves_like "a job that adheres to the auto_evaluation quota", AutoEvaluation::AnswerRelevancy
+  it_behaves_like "a job that retries on service errors", Aws::Errors::ServiceError do
+    before do
+      allow(AutoEvaluation::AnswerRelevancy)
+        .to receive(:call)
+        .and_raise(Aws::Errors::ServiceError.new(nil, "error"))
+    end
+  end
 
   describe "#perform" do
     it "calls AutoEvaluation::AnswerRelevancy the configured number of times with the correct arguments" do
@@ -119,21 +126,6 @@
       end
     end
 
-    context "when the AnswerRelevancy metric raises an Aws::Errors::ServiceError" do
-      it "retries the job the max number of times" do
-        allow(AutoEvaluation::AnswerRelevancy)
-          .to receive(:call)
-          .and_raise(Aws::Errors::ServiceError.new(nil, "error"))
-
-        described_class.perform_later(answer.id)
-
-        assert_performed_jobs described_class::MAX_RETRIES do
-          expect { perform_enqueued_jobs }
-            .to raise_error(Aws::Errors::ServiceError)
-        end
-      end
-    end
-
     context "when the answer is not eligible for auto-evaluation" do
       let(:answer) { create(:answer, status: Answer.statuses.except(:answered).keys.sample) }
 

spec/jobs/answer_analysis/tag_topics_job_spec.rb

@@ -20,6 +20,13 @@
 
   it_behaves_like "a job in queue", "default"
   it_behaves_like "a job that adheres to the auto_evaluation quota", AutoEvaluation::TopicTagger
+  it_behaves_like "a job that retries on service errors", Anthropic::Errors::APIError do
+    before do
+      allow(AutoEvaluation::TopicTagger)
+        .to receive(:call)
+        .and_raise(Anthropic::Errors::APIError.new(url: "url"))
+    end
+  end
 
   describe "#perform" do
     it "calls the AutoEvaluation::TopicTagger with the answer message" do
@@ -69,23 +76,6 @@
       end
     end
 
-    context "when AutoEvaluation::TopicTagger raises an Anthropic::Errors::APIError" do
-      it "retries the job the max number of times" do
-        allow(AutoEvaluation::TopicTagger).to receive(:call)
-          .and_raise(Anthropic::Errors::APIError.new(
-                       url: "url",
-                     ))
-
-        (described_class::MAX_RETRIES - 1).times do
-          described_class.perform_later(answer.id)
-          expect { perform_enqueued_jobs }.not_to raise_error
-        end
-
-        described_class.perform_later(answer.id)
-        expect { perform_enqueued_jobs }.to raise_error(Anthropic::Errors::APIError)
-      end
-    end
-
     context "when the answer is not eligible for topic analysis" do
       let(:answer) { create(:answer, status: Answer::STATUSES_EXCLUDED_FROM_TOPIC_ANALYSIS.sample) }
 

spec/support/job_examples.rb

@@ -37,4 +37,16 @@ module JobExamples
       described_class.new.perform(answer.id)
     end
   end
+
+  shared_examples "a job that retries on service errors" do |error_class|
+    let(:answer) { create(:answer) }
+    it "retries the job the max number of times on #{error_class}" do
+      described_class.perform_later(answer.id)
+
+      assert_performed_jobs described_class::MAX_RETRIES do
+        expect { perform_enqueued_jobs }
+          .to raise_error(error_class)
+      end
+    end
+  end
 end