Update guardrail pipeline steps to use class methods

This brings these inline with the rest of the pipeline steps and allows
them to be called without needing to instantiate an instance of the class.

Author: davidgisbey

lib/answer_composition/pipeline/answer_guardrails.rb

@@ -1,7 +1,7 @@
 module AnswerComposition
   module Pipeline
     class AnswerGuardrails < OutputGuardrails
-      def call(context)
+      def call
         start_time = Clock.monotonic_time
         response = generate_response(context)
 

lib/answer_composition/pipeline/output_guardrails.rb

@@ -1,14 +1,16 @@
 module AnswerComposition
   module Pipeline
     class OutputGuardrails
-      def initialize(llm_provider: :claude)
-        @llm_provider = llm_provider
+      attr_reader :context
+
+      def self.call(...) = new(...).call
+
+      def initialize(context)
+        @context = context
       end
 
     protected
 
-      attr_reader :llm_provider
-
       def build_metrics(start_time, response_or_error)
         {
           duration: Clock.monotonic_time - start_time,

lib/answer_composition/pipeline/question_routing_guardrails.rb

@@ -1,7 +1,7 @@
 module AnswerComposition
   module Pipeline
     class QuestionRoutingGuardrails < OutputGuardrails
-      def call(context)
+      def call
         return if context.answer.question_routing_label == "genuine_rag"
 
         start_time = Clock.monotonic_time

spec/lib/answer_composition/pipeline/answer_guardrails_spec.rb

@@ -1,20 +1,16 @@
 RSpec.describe AnswerComposition::Pipeline::AnswerGuardrails do
   let(:context) { build(:answer_pipeline_context) }
   let(:message) { "sample answer message" }
+  let(:guardrail_response) { build(:guardrails_multiple_checker_result, :pass) }
 
   before do
     context.answer.message = message
     allow(Guardrails::MultipleChecker).to receive(:call).and_return(guardrail_response)
   end
 
-  context "when the llm_provider is :claude" do
-    let(:llm_provider) { :claude }
-    let(:guardrail_response) { build(:guardrails_multiple_checker_result, :pass) }
-
-    it "initializes the calls Guardrails::MultipleChecker with Claude as the provider" do
-      described_class.new(llm_provider: llm_provider).call(context)
-      expect(Guardrails::MultipleChecker).to have_received(:call).with(message, "answer_guardrails")
-    end
+  it "calls the Guardrails::MultipleChecker with the correct parameters" do
+    described_class.call(context)
+    expect(Guardrails::MultipleChecker).to have_received(:call).with(message, "answer_guardrails")
   end
 
   context "when the guardrails are not triggered" do
@@ -23,7 +19,7 @@
     it_behaves_like "a passing guardrail pipeline step", "answer_guardrails"
 
     it "does not abort the pipeline" do
-      described_class.new(llm_provider: :claude).call(context)
+      described_class.call(context)
       expect(context.aborted?).to be false
     end
   end
@@ -33,7 +29,7 @@
 
     it "aborts the pipeline and updates the answer's status and message attributes" do
       expect {
-        described_class.new(llm_provider: :claude).call(context)
+        described_class.call(context)
       }.to throw_symbol(:abort)
 
       expect(context.answer).to have_attributes(
@@ -45,14 +41,14 @@
     end
 
     it "assigns the llm response to the answer" do
-      expect { described_class.new(llm_provider: :claude).call(context) }.to throw_symbol(:abort)
+      expect { described_class.call(context) }.to throw_symbol(:abort)
       expect(context.answer.llm_responses["answer_guardrails"]).to eq(guardrail_response.llm_response)
     end
 
     it "assigns metrics to the answer" do
       allow(Clock).to receive(:monotonic_time).and_return(100.0, 101.5)
 
-      expect { described_class.new(llm_provider: :claude).call(context) }.to throw_symbol(:abort)
+      expect { described_class.call(context) }.to throw_symbol(:abort)
 
       expect(context.answer.metrics["answer_guardrails"]).to eq({
         duration: 1.5,

spec/lib/answer_composition/pipeline/question_routing_guardrails_spec.rb

@@ -1,20 +1,16 @@
 RSpec.describe AnswerComposition::Pipeline::QuestionRoutingGuardrails do
   let(:context) { build(:answer_pipeline_context) }
   let(:message) { "sample answer message" }
+  let(:guardrail_response) { build(:guardrails_multiple_checker_result, :pass) }
 
   before do
     context.answer.message = message
     allow(Guardrails::MultipleChecker).to receive(:call).and_return(guardrail_response)
   end
 
-  context "when the llm_provider is :claude" do
-    let(:llm_provider) { :claude }
-    let(:guardrail_response) { build(:guardrails_multiple_checker_result, :pass) }
-
-    it "initializes the calls Guardrails::MultipleChecker with Claude as the provider" do
-      described_class.new(llm_provider: llm_provider).call(context)
-      expect(Guardrails::MultipleChecker).to have_received(:call).with(message, "question_routing_guardrails", llm_provider)
-    end
+  it "calls the Guardrails::MultipleChecker with the correct parameters" do
+    described_class.call(context)
+    expect(Guardrails::MultipleChecker).to have_received(:call).with(message, "question_routing_guardrails")
   end
 
   context "when the guardrails are not triggered" do
@@ -27,11 +23,11 @@
 
       context.answer.question_routing_label = "genuine_rag"
 
-      described_class.new(llm_provider: :claude).call(context)
+      described_class.call(context)
     end
 
     it "aborts the pipeline" do
-      described_class.new(llm_provider: :claude).call(context)
+      described_class.call(context)
       expect(context.aborted?).to be true
     end
   end
@@ -40,7 +36,7 @@
     let(:guardrail_response) { build(:guardrails_multiple_checker_result, :fail) }
 
     it "sets the attributes on the answer" do
-      described_class.new(llm_provider: :claude).call(context)
+      described_class.call(context)
 
       expect(context.answer).to have_attributes({
         message: Answer::CannedResponses::QUESTION_ROUTING_GUARDRAILS_FAILED_MESSAGE,
@@ -50,7 +46,7 @@
     end
 
     it "aborts the pipeline and assigns the right attributes" do
-      described_class.new(llm_provider: :claude).call(context)
+      described_class.call(context)
 
       expect(context.aborted?).to be true
       expect(context.answer.question_routing_guardrails_status).to eq("fail")

spec/support/guardrails_examples.rb

@@ -1,23 +1,23 @@
 module GuardrailsExamples
   shared_examples "a passing guardrail pipeline step" do |guardrail_name|
     it "calls the guardrails with the answer message" do
-      described_class.new.call(context)
+      described_class.call(context)
       expect(Guardrails::MultipleChecker)
         .to have_received(:call)
-        .with(context.answer.message, guardrail_name, :claude)
+        .with(context.answer.message, guardrail_name)
     end
 
     it "does not change the message" do
-      expect { described_class.new.call(context) }.not_to change(context.answer, :message)
+      expect { described_class.call(context) }.not_to change(context.answer, :message)
     end
 
     it "sets the status" do
-      expect { described_class.new.call(context) }
+      expect { described_class.call(context) }
         .to change(context.answer, "#{guardrail_name}_status").to("pass")
     end
 
     it "assigns the llm response to the answer" do
-      described_class.new.call(context)
+      described_class.call(context)
 
       expect(context.answer.llm_responses[guardrail_name])
         .to eq(guardrail_response.llm_response)
@@ -26,7 +26,7 @@ module GuardrailsExamples
     it "assigns metrics to the answer" do
       allow(Clock).to receive(:monotonic_time).and_return(100.0, 101.5)
 
-      described_class.new.call(context)
+      described_class.call(context)
 
       expect(context.answer.metrics[guardrail_name]).to eq({
         duration: 1.5,
@@ -64,7 +64,7 @@ module GuardrailsExamples
       end
 
       it "aborts the pipeline and updates the answer's status with an error message" do
-        expect { described_class.new.call(context) }.to throw_symbol(:abort)
+        expect { described_class.call(context) }.to throw_symbol(:abort)
         expect(context.answer).to have_attributes(
           message:,
           status: "error_#{guardrail_name}",
@@ -73,14 +73,14 @@ module GuardrailsExamples
       end
 
       it "assigns the llm response to the answer" do
-        expect { described_class.new.call(context) }.to throw_symbol(:abort)
+        expect { described_class.call(context) }.to throw_symbol(:abort)
         expect(context.answer.llm_responses[guardrail_name]).to eq(llm_response)
       end
 
       it "assigns metrics to the answer" do
         allow(Clock).to receive(:monotonic_time).and_return(100.0, 101.5)
 
-        expect { described_class.new.call(context) }.to throw_symbol(:abort)
+        expect { described_class.call(context) }.to throw_symbol(:abort)
 
         expect(context.answer.metrics[guardrail_name]).to eq({
           duration: 1.5,