Merge pull request #967 from alphagov/follow-up-changes-to-llm-resposnes-and-metrics-default-change

[CHAT-417]Backfill llm_responses and metrics nil values and make columns non-nullable

Author: davidgisbey

db/migrate/20260326122659_backfill_nilvalues_for_llm_responses_and_metrics.rb

@@ -0,0 +1,27 @@
+class BackfillNilvaluesForLlmResponsesAndMetrics < ActiveRecord::Migration[8.0]
+  class AnswerAnalysisAnswerRelevancyRun < ApplicationRecord; end
+  class AnswerAnalysisCoherenceRun < ApplicationRecord; end
+  class AnswerAnalysisContextRelevancyRun < ApplicationRecord; end
+  class AnswerAnalysisFaithfulnessRun < ApplicationRecord; end
+  class AnswerAnalysisTopics < ApplicationRecord; end
+
+  MODELS = [
+    AnswerAnalysisAnswerRelevancyRun,
+    AnswerAnalysisCoherenceRun,
+    AnswerAnalysisContextRelevancyRun,
+    AnswerAnalysisFaithfulnessRun,
+    AnswerAnalysisTopics,
+    Answer,
+  ].freeze
+
+  def up
+    MODELS.each do |model|
+      model.where(metrics: nil).update_all(metrics: {})
+      model.where(llm_responses: nil).update_all(llm_responses: {})
+    end
+  end
+
+  def down
+    raise ActiveRecord::IrreversibleMigration
+  end
+end

db/migrate/20260326123210_make_llm_responses_and_metrics_non_nullable.rb

@@ -0,0 +1,19 @@
+class MakeLlmResponsesAndMetricsNonNullable < ActiveRecord::Migration[8.0]
+  TABLES = %i[
+    answers
+    answer_analysis_answer_relevancy_runs
+    answer_analysis_coherence_runs
+    answer_analysis_context_relevancy_runs
+    answer_analysis_faithfulness_runs
+    answer_analysis_topics
+  ].freeze
+
+  def change
+    TABLES.each do |table|
+      change_table table, bulk: true do |t|
+        t.change_null :metrics, false
+        t.change_null :llm_responses, false
+      end
+    end
+  end
+end

db/schema.rb

@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema[8.0].define(version: 2026_03_24_105142) do
+ActiveRecord::Schema[8.0].define(version: 2026_03_26_123210) do
   # These are extensions that must be enabled in order to support this database
   enable_extension "citext"
   enable_extension "pg_catalog.plpgsql"
@@ -29,8 +29,8 @@
   create_table "answer_analysis_answer_relevancy_runs", id: :uuid, default: -> { "gen_random_uuid()" }, force: :cascade do |t|
     t.decimal "score"
     t.string "reason"
-    t.jsonb "llm_responses", default: {}
-    t.jsonb "metrics", default: {}
+    t.jsonb "llm_responses", default: {}, null: false
+    t.jsonb "metrics", default: {}, null: false
     t.uuid "answer_id", null: false
     t.datetime "created_at", null: false
     t.datetime "updated_at", null: false
@@ -42,8 +42,8 @@
   create_table "answer_analysis_coherence_runs", id: :uuid, default: -> { "gen_random_uuid()" }, force: :cascade do |t|
     t.decimal "score"
     t.string "reason"
-    t.jsonb "llm_responses", default: {}
-    t.jsonb "metrics", default: {}
+    t.jsonb "llm_responses", default: {}, null: false
+    t.jsonb "metrics", default: {}, null: false
     t.uuid "answer_id", null: false
     t.datetime "created_at", null: false
     t.datetime "updated_at", null: false
@@ -55,8 +55,8 @@
   create_table "answer_analysis_context_relevancy_runs", id: :uuid, default: -> { "gen_random_uuid()" }, force: :cascade do |t|
     t.decimal "score"
     t.string "reason"
-    t.jsonb "llm_responses", default: {}
-    t.jsonb "metrics", default: {}
+    t.jsonb "llm_responses", default: {}, null: false
+    t.jsonb "metrics", default: {}, null: false
     t.uuid "answer_id", null: false
     t.datetime "created_at", null: false
     t.datetime "updated_at", null: false
@@ -68,8 +68,8 @@
   create_table "answer_analysis_faithfulness_runs", id: :uuid, default: -> { "gen_random_uuid()" }, force: :cascade do |t|
     t.decimal "score"
     t.string "reason"
-    t.jsonb "llm_responses", default: {}
-    t.jsonb "metrics", default: {}
+    t.jsonb "llm_responses", default: {}, null: false
+    t.jsonb "metrics", default: {}, null: false
     t.uuid "answer_id", null: false
     t.datetime "created_at", null: false
     t.datetime "updated_at", null: false
@@ -81,8 +81,8 @@
   create_table "answer_analysis_topics", id: :uuid, default: -> { "gen_random_uuid()" }, force: :cascade do |t|
     t.string "primary_topic"
     t.string "secondary_topic"
-    t.jsonb "metrics", default: {}
-    t.jsonb "llm_responses", default: {}
+    t.jsonb "metrics", default: {}, null: false
+    t.jsonb "llm_responses", default: {}, null: false
     t.uuid "answer_id", null: false
     t.datetime "created_at", null: false
     t.datetime "updated_at", null: false
@@ -146,8 +146,8 @@
     t.string "answer_guardrails_failures", default: [], array: true
     t.enum "question_routing_label", enum_type: "question_routing_label"
     t.float "question_routing_confidence_score"
-    t.jsonb "metrics", default: {}
-    t.jsonb "llm_responses", default: {}
+    t.jsonb "metrics", default: {}, null: false
+    t.jsonb "llm_responses", default: {}, null: false
     t.enum "jailbreak_guardrails_status", enum_type: "guardrails_status"
     t.enum "question_routing_guardrails_status", enum_type: "guardrails_status"
     t.string "question_routing_guardrails_failures", default: [], array: true