Add coherence to the question show page in the admin UI

This adds the coherence evaluation runs to the analysis tab of the question
show page in the admin interface. It mirrors the existing answer relevancy
runs display.

Author: davidgisbey

app/controllers/admin/questions_controller.rb

@@ -7,7 +7,7 @@ def index
   def show
     question_scope = Question.includes(
       conversation: :signon_user,
-      answer: [{ sources: :chunk }, :feedback, :topics, :answer_relevancy_runs],
+      answer: [{ sources: :chunk }, :feedback, :topics, :answer_relevancy_runs, :coherence_runs],
     )
 
     @question = question_scope.find(params[:id])

app/models/answer.rb

@@ -203,7 +203,9 @@ def group_used_answer_sources_by_base_path
   end
 
   def has_analysis?
-    topics.present? || answer_relevancy_runs.present?
+    topics.present? ||
+      answer_relevancy_runs.present? ||
+      coherence_runs.present?
   end
 
   def question_used

app/views/admin/questions/_analysis_tab.html.erb

@@ -49,3 +49,7 @@
 <% if answer_relevancy_runs.present? %>
   <%= render "generic_auto_evaluation_runs", runs: answer_relevancy_runs, title: "Answer relevancy" %>
 <% end %>
+
+<% if coherence_runs.present? %>
+  <%= render "generic_auto_evaluation_runs", runs: coherence_runs, title: "Coherence" %>
+<% end %>

app/views/admin/questions/show.html.erb

@@ -40,6 +40,7 @@ content_for(:active_navigation_item, admin_questions_path)
       "analysis_tab",
       topics: @answer.topics,
       answer_relevancy_runs: @answer.answer_relevancy_runs,
+      coherence_runs: @answer.coherence_runs,
     ),
   } if @answer&.has_analysis?
 %>

spec/models/answer_spec.rb

@@ -360,11 +360,14 @@
       expect(answer.has_analysis?).to be(true)
     end
 
-    it "returns true if answer_relevancy_runs are present" do
-      answer = build(
-        :answer, answer_relevancy_runs: [build(:answer_relevancy_run)]
-      )
-      expect(answer.has_analysis?).to be(true)
+    %i[answer_relevancy_runs coherence_runs].each do |run_association|
+      it "returns true if #{run_association} are present" do
+        answer = build(
+          :answer, "#{run_association}": [build(run_association.to_s.singularize)]
+        )
+
+        expect(answer.has_analysis?).to be(true)
+      end
     end
 
     it "returns false if no analysis is present" do

spec/requests/admin/questions_spec.rb

@@ -175,6 +175,59 @@
   end
 
   describe "GET :show" do
+    shared_examples "renders_run in analysis tab when present" do |run_association, title|
+      context "when #{run_association} data is present" do
+        let(:run) do
+          create(
+            run_association,
+            score: 0.85,
+            reason: "The answer was acceptable.",
+            llm_responses: {
+              "verdicts" => { "verdicts" => [{ "verdict" => "yes" }] },
+              "reason" => { "reason" => ["The answer was acceptable."] },
+
+            },
+            metrics: {
+              "verdicts" => { duration: 1.44445 },
+              "reason" => { duration: 1.55556 },
+            },
+          )
+        end
+        let(:question) { run.answer.question }
+
+        it "renders #{run_association} details in the analysis tab" do
+          get admin_show_question_path(question)
+
+          expect(response.body)
+            .to have_selector("#analysis-tab", text: title)
+            .and have_selector("#analysis-tab", text: /Mean score\s*0\.85/)
+            .and have_selector("#analysis-tab", text: /Run 1 score\s*0\.85/)
+            .and have_selector("#analysis-tab", text: /Run 1 reason\s*The answer was acceptable\./)
+        end
+
+        it "renders the runs llm responses" do
+          get admin_show_question_path(question)
+
+          expect(response.body.squish)
+            .to have_content('{ "verdicts": [ { "verdict": "yes" } ] }')
+            .and have_content('{ "reason": [ "The answer was acceptable." ] }')
+        end
+
+        it "renders the runs metrics" do
+          get admin_show_question_path(question)
+
+          expect(response.body.squish)
+            .to have_content("Verdicts")
+            .and have_content(/duration.*1\.44445/)
+            .and have_content("Reason")
+            .and have_content(/duration.*1\.55556/)
+        end
+      end
+    end
+
+    it_behaves_like "renders_run in analysis tab when present", :answer_relevancy_run, "Answer relevancy"
+    it_behaves_like "renders_run in analysis tab when present", :coherence_run, "Coherence"
+
     it "renders the page successfully" do
       question = create(:question)
       get admin_show_question_path(question)
@@ -284,7 +337,7 @@
         .and have_content('"id": "call_dqGpbb39drQDafLsjDLtnbGD"')
     end
 
-    it "doesn't render the tabs component when there are no topics or auto-eval aggregate data" do
+    it "doesn't render the tabs component there is no analysis data" do
       question = create(:question, :with_answer)
       get admin_show_question_path(question)
 
@@ -361,54 +414,6 @@
          .and have_selector("#analysis-tab", text: topics.secondary_topic.capitalize)
       end
     end
-
-    context "when answer relevancy aggregate data is present" do
-      let(:run) do
-        create(
-          :answer_relevancy_run,
-          score: 0.85,
-          reason: "The answer is relevant to the question.",
-          llm_responses: {
-            "statements" => { "statements" => ["The answer is relevant."] },
-            "verdicts" => { "verdicts" => [{ "verdict" => "yes" }] },
-          },
-          metrics: {
-            "statements" => { duration: 1.55556 },
-            "verdicts" => { duration: 1.44445 },
-          },
-        )
-      end
-      let(:question) { run.answer.question }
-
-      it "renders the answer relevancy aggregate and run details" do
-        get admin_show_question_path(question)
-
-        expect(response.body.squish)
-          .to have_content("Answer relevancy")
-          .and have_content("Run 1 score")
-          .and have_content("0.85")
-          .and have_content("Run 1 reason")
-          .and have_content("The answer is relevant to the question.")
-      end
-
-      it "renders the runs llm responses" do
-        get admin_show_question_path(question)
-
-        expect(response.body.squish)
-          .to have_content('{ "statements": [ "The answer is relevant." ] }')
-          .and have_content('{ "verdicts": [ { "verdict": "yes" } ] }')
-      end
-
-      it "renders the runs metrics" do
-        get admin_show_question_path(question)
-
-        expect(response.body.squish)
-          .to have_content("Statements")
-          .and have_content(/duration.*1\.55556/)
-          .and have_content("Verdicts")
-          .and have_content(/duration.*1\.44445/)
-      end
-    end
   end
 
   def expect_unprocessable_content_with_date_errors