Extend quota limit to AnswerTopicsJob

We're treating topic tagging as a metric. This means we need to extend
the quota to include AnswerTopicsJob so that both jobs implement quota
adherence.

I've added a shared example to tests related to the quota.

Author: davidgisbey

app/jobs/answer_analysis/tag_topics_job.rb

@@ -1,6 +1,5 @@
 module AnswerAnalysis
-  class TagTopicsJob < ApplicationJob
-    MAX_RETRIES = 5
+  class TagTopicsJob < BaseMetricJob
     retry_on Anthropic::Errors::APIError, wait: 1.minute, attempts: MAX_RETRIES
 
     def perform(answer_id)
@@ -11,6 +10,7 @@ def perform(answer_id)
       unless answer.eligible_for_topic_analysis?
         return logger.info("Answer #{answer_id} is not eligible for topic analysis")
       end
+      return if quota_limit_reached?
 
       result = AutoEvaluation::TopicTagger.call(answer.rephrased_question || answer.question.message)
 

spec/jobs/answer_analysis/answer_relevancy_job_spec.rb

@@ -53,10 +53,10 @@
     allow(AutoEvaluation::AnswerRelevancy)
       .to receive(:call).and_return(first_result, second_result, third_result)
     stub_const("AnswerAnalysis::BaseMetricJob::NUMBER_OF_RUNS", 3)
-    allow(Rails.configuration).to receive(:max_auto_evaluation_metrics_per_hour).and_return(2)
   end
 
   it_behaves_like "a job in queue", "default"
+  it_behaves_like "a job that adheres to the metric quota", AutoEvaluation::AnswerRelevancy
 
   describe "#perform" do
     it "calls AutoEvaluation::AnswerRelevancy the configured number of times with the correct arguments" do
@@ -99,31 +99,6 @@
       end
     end
 
-    it "writes the auto_evaluation_metrics_run_count cache key on the first metric run" do
-      expect(Rails.cache).to receive(:write)
-                         .with("auto_evaluation_metrics_run_count", 1, expires_in: 1.hour)
-
-      described_class.new.perform(answer.id)
-    end
-
-    it "increments the auto_evaluation_metrics_run_count cache key in subsequent runs" do
-      allow(Rails.cache).to receive(:read).with("auto_evaluation_metrics_run_count").and_return(1)
-      expect(Rails.cache).to receive(:increment)
-                         .with("auto_evaluation_metrics_run_count")
-
-      described_class.new.perform(answer.id)
-    end
-
-    it "logs info and does not perform evaluation when quota limit is reached" do
-      allow(Rails.cache).to receive(:read).with("auto_evaluation_metrics_run_count").and_return(2)
-      expect(described_class.logger)
-        .to receive(:warn)
-        .with("Auto-evaluation quota limit of 2 metrics per hour reached")
-      expect(AutoEvaluation::AnswerRelevancy).not_to receive(:call)
-
-      described_class.new.perform(answer.id)
-    end
-
     context "when the answer has a rephrased_question" do
       let(:rephrased_question) { "This is a rephrased_question" }
 

spec/jobs/answer_analysis/tag_topics_job_spec.rb

@@ -19,6 +19,7 @@
   before { allow(AutoEvaluation::TopicTagger).to receive(:call).and_return(topic_tagger_result) }
 
   it_behaves_like "a job in queue", "default"
+  it_behaves_like "a job that adheres to the metric quota", AutoEvaluation::TopicTagger
 
   describe "#perform" do
     it "calls the AutoEvaluation::TopicTagger with the answer message" do
@@ -34,8 +35,8 @@
         .to have_attributes(
           primary_topic: topic_tagger_result.primary_topic,
           secondary_topic: topic_tagger_result.secondary_topic,
-          metrics: { "topic_tagger" => topic_tagger_result.metrics },
-          llm_responses: { "topic_tagger" => topic_tagger_result.llm_response },
+          metrics: topic_tagger_result.metrics,
+          llm_response: topic_tagger_result.llm_response,
         )
     end
 
@@ -78,23 +79,6 @@
       end
     end
 
-    context "when AutoEvaluation::TopicTagger raises an Anthropic::Errors::APIError" do
-      it "retries the job the max number of times" do
-        allow(AutoEvaluation::TopicTagger).to receive(:call)
-          .and_raise(Anthropic::Errors::APIError.new(
-                       url: "url",
-                     ))
-
-        (described_class::MAX_RETRIES - 1).times do
-          described_class.perform_later(answer.id)
-          expect { perform_enqueued_jobs }.not_to raise_error
-        end
-
-        described_class.perform_later(answer.id)
-        expect { perform_enqueued_jobs }.to raise_error(Anthropic::Errors::APIError)
-      end
-    end
-
     context "when the answer is not eligible for topic analysis" do
       let(:answer) { create(:answer, status: Answer::STATUSES_EXCLUDED_FROM_TOPIC_ANALYSIS.sample) }
 

spec/support/job_examples.rb

@@ -4,4 +4,35 @@ module JobExamples
       expect(described_class.queue_name).to eq(expected_queue)
     end
   end
+
+  shared_examples "a job that adheres to the metric quota" do |metric|
+    let(:answer) { create(:answer) }
+
+    before { allow(Rails.configuration).to receive(:max_auto_evaluation_metrics_per_hour).and_return(2) }
+
+    it "writes the auto_evaluation_metrics_run_count cache key on the first metric run" do
+      expect(Rails.cache).to receive(:write)
+                         .with("auto_evaluation_metrics_run_count", 1, expires_in: 1.hour)
+
+      described_class.new.perform(answer.id)
+    end
+
+    it "increments the auto_evaluation_metrics_run_count cache key in subsequent runs" do
+      allow(Rails.cache).to receive(:read).with("auto_evaluation_metrics_run_count").and_return(1)
+      expect(Rails.cache).to receive(:increment)
+                         .with("auto_evaluation_metrics_run_count")
+
+      described_class.new.perform(answer.id)
+    end
+
+    it "logs info and does not perform evaluation when quota limit is reached" do
+      allow(Rails.cache).to receive(:read).with("auto_evaluation_metrics_run_count").and_return(2)
+      expect(described_class.logger)
+        .to receive(:warn)
+        .with("Auto-evaluation quota limit of 2 metrics per hour reached")
+      expect(metric).not_to receive(:call)
+
+      described_class.new.perform(answer.id)
+    end
+  end
 end