Skip to content

Commit 5829801

Browse files
committed
Document what to do if you're opening a PR in a repo with code owners
1 parent 257136d commit 5829801

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

source/manual/merge-pr.html.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,3 +84,6 @@ If two developers worked on the same branch and individually contributed commits
8484
2. It's OK for someone other than the author to merge a PR, particularly if the author is not available. That person should be confident that the change doesn't have dependencies on other changes, and that it won't break `main`.
8585
3. If a PR is particularly good, remember to praise the author for it. Emoji are a great way of showing appreciation for a PR that fixes a problem you've been having, or implements something you've wanted to do for a while.
8686
4. It's sometimes OK for merges to happen when test suites are failing. This ability is limited to repository administrators and account owners, so ask them if you need them to force a merge. This is particularly useful in a catch-22 situation of two repositories with failing test suites that depend on each other.
87+
5. Some repositories have code owners set for either the entire repository or specific files/directories.
88+
This is so the people responsible for the repository have a chance to review changes made to important files.
89+
If a PR changes files that have a code owner, you should get a review as usual and one from a code owner.

0 commit comments

Comments
 (0)