Skip to content

Commit 00bafa4

Browse files
committed
Move for loop into array method
1 parent 91909e9 commit 00bafa4

1 file changed

Lines changed: 13 additions & 10 deletions

File tree

shared/tasks/browser.mjs

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -29,16 +29,14 @@ export async function screenshots() {
2929
// Screenshot components
3030
for (const componentName of componentNames) {
3131
const allExamples = await getExamples(componentName)
32-
const componentExampleNames = Object.keys(allExamples).filter(
33-
(key) => allExamples[key].fixture.screenshot
34-
)
35-
36-
for (const exampleName of componentExampleNames) {
37-
await screenshotComponent(browser, componentName, {
38-
screenshot: allExamples[exampleName].fixture.screenshot,
39-
exampleName
40-
})
41-
}
32+
Object.keys(allExamples).forEach(async (exampleName) => {
33+
if (allExamples[exampleName].fixture.screenshot) {
34+
await screenshotComponent(browser, componentName, {
35+
screenshot: allExamples[exampleName].fixture.screenshot,
36+
exampleName
37+
})
38+
}
39+
})
4240
}
4341

4442
// Screenshot specific example pages
@@ -73,6 +71,11 @@ export async function screenshots() {
7371
* Send single component screenshots to Percy
7472
* for visual regression testing
7573
*
74+
* Current screenshot variants include:
75+
*
76+
* - `default` - Default screenshot with JavaScript enabled
77+
* - `no-js` - Screenshot with JavaScript disabled
78+
*
7679
* @param {Browser} browser - Puppeteer browser object
7780
* @param {string} componentName - Component name
7881
* @param {object} options - Component options

0 commit comments

Comments
 (0)