Skip to content

Commit b0f59a1

Browse files
committed
Resolve class ordering issue
1 parent f57795c commit b0f59a1

2 files changed

Lines changed: 7 additions & 10 deletions

File tree

packages/govuk-frontend/src/govuk/components/panel/template.njk

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,14 @@
22

33
{% set headingLevel = params.headingLevel if params.headingLevel else 1 -%}
44

5-
{%- set classNames = "govuk-panel" -%}
5+
{%- set isInterruption = params.classes and ("govuk-panel--interruption" in params.classes) -%}
66

7-
{%- if params.classes %}
8-
{% set classNames = classNames + " " + params.classes %}
9-
{% endif %}
7+
{#- The Panel component defaults to the Confirmation variant -#}
8+
{%- set defaultModifierClassName = "govuk-panel--confirmation" if not isInterruption -%}
109

11-
{%- if (not params.classes) or (not "govuk-panel--interruption" in params.classes) %}
12-
{% set classNames = classNames + " govuk-panel--confirmation" -%}
13-
{% endif %}
14-
15-
<div class="{{ classNames }}"
10+
<div class="govuk-panel
11+
{%- if defaultModifierClassName %} {{ defaultModifierClassName }}{% endif %}
12+
{%- if params.classes %} {{ params.classes }}{% endif -%}"
1613
{{- govukAttributes(params.attributes) }}>
1714
<h{{ headingLevel }} class="govuk-panel__title">
1815
{{ params.titleHtml | safe if params.titleHtml else params.titleText }}

packages/govuk-frontend/src/govuk/components/panel/template.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ describe('Panel', () => {
120120

121121
const $component = $('.govuk-panel')
122122
expect($component.attr('class')).toBe(
123-
'govuk-panel extra-class one-more-class govuk-panel--confirmation'
123+
'govuk-panel govuk-panel--confirmation extra-class one-more-class'
124124
)
125125
})
126126
it('has no confirmation modifier class if interruption modifier class is used', () => {

0 commit comments

Comments
 (0)