Commit e9912f9
committed
Remove use of pre-compiled fixtures on Heroku and CI
The `render` function was using the content from the `html` fields in `fixtures.json`.
This made it unpredictable when updating examples's `context` for rendering with the `rebrand` flag
which we need:
- for the review app, to render component examples respecting the feature flag toggled in the UI
- in tests, to enable adjusting existing examples by updating their context in the test themselves rather than adding more examples
Comparing test duration [with caching](https://github.com/alphagov/govuk-frontend/actions/runs/14241757022?pr=5795)
and [without caching](https://github.com/alphagov/govuk-frontend/actions/runs/14265204592), no flagrant difference appears (both on initial run and subsequent runs),
so I've removed the caching from the `render` helper in components to make its behaviour more predictable.1 parent b2e8c63 commit e9912f9
1 file changed
Lines changed: 0 additions & 7 deletions
File tree
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
155 | 155 | | |
156 | 156 | | |
157 | 157 | | |
158 | | - | |
159 | | - | |
160 | | - | |
161 | | - | |
162 | | - | |
163 | | - | |
164 | | - | |
165 | 158 | | |
166 | 159 | | |
167 | 160 | | |
| |||
0 commit comments