Add interruption panel#6636
Conversation
|
Thanks for proposing this @frankieroberto ! We're currently all hands on deck finalising v6.0 so we've added a reminder to our roadmap to prioritise having a look after we're through 😊 |
|
@romaricpascal thank you! Would you mind approving the workflow again so I can check the tests are now passing? Good luck with v6! |
|
Well done on getting v6 out! 🙌 Can I nudge you on reviewing the interruption panel suggestion when you a moment? Happy to help with any guidance if needed. |
|
Sorry for the delay @frankieroberto. Following v6, we've had to pivot to focus on some organisational changes which has taken us away from our regular sprint work. We're hoping to review your suggestion in the next few weeks 🙏🏻 |
|
Hi @frankieroberto, thanks for making this contribution. We’ve put together a small squad to think about this. We’re supportive of publishing this as a variant in the Panel component. To do this, we’d still need some things. Minimal usage guidance:
Summary of relevant supporting evidence:
Other things to consider:
Would you be able to help put some of this together? We thought you’ve probably got a view of most of this already. |
|
@calvin-lau-sig7 I’m happy to help but I don’t have loads of time at the moment. We collated some examples from the NHS for our design system: https://service-manual.nhs.uk/design-system/patterns/interruption-page – you’re welcome to borrow any of that. I’m a bit out of the loop now on GOV.UK branded services, but I’m sure there are some live examples (a few on alphagov/govuk-design-system-backlog#27 ) - could be worth asking on the cross-gov Slack? The MOJ team did a lot of working looking into it too for their pattern so they may have some more examples from live services. |
|
@calvin-lau-sig7 oh and for the action links, I think rather than supporting That’s the approach we took on the NHS design system anyway. The guidance can still suggest only using a single button, with or without a link, but the component itself is flexible. There are already |
|
Good stuff, thanks @frankieroberto! Just checking how involved you wanted or could be on this. |
|
@calvin-lau-sig7 feel free to invite me to anything and I'll come if I can! Would you also mind approving the workflow so we can check that the tests still pass? Is it also possible to trigger the preview deployment so that you can all see proposed component variant? |
|
@frankieroberto It just needs a rebase because we've fiddled with the required tests. Gimme a sec I can do it |
|
@owenatgov have added you to the fork at https://github.com/x-govuk/govuk-frontend - free free to push to the branch! |
In common with other components, the panel doesn't meet the AAA contrast ratio of 7:1 for small text (under 24px) The contrast ratio for white text on blue panels is 5.16:1 The contrast ratio for white text on green panels is 4.52:1 (however by default these use large text)
8b5d672 to
7839346
Compare
|
@frankieroberto Aha that's that permission problem I was getting sorted 😁 Thanks! Done. Tests should run as normal now. |
|
Those test failures are coming from our new snapshot tests which we've introduced as part of the wider work to move from |
|
@owenatgov thanks! Is it possible to get the preview deploying, or does that not work from contributions from outside the team? |
|
@frankieroberto Ah sorry I glossed over that part of your earlier comment. I've just created one. |
|
Hi @frankieroberto, wanted to give an update on behalf of the team again. We've done some desk research to gather the use cases and supporting evidence. We've concluded that the most practical and suitable solution for us to publish this is to:
We're expecting to have something ready to review as a revamped PR/preview in a few weeks time! |
|
@calvin-lau-sig7 nice! We took a similar decision to make it a variant of the Panel component rather than its own component (although MOJ Design System made it a standalone component). We did briefly debate what modifier to use in the CSS, considering You’ll also have to consider whether to apply the |
|
Hey @frankieroberto. We'd like to hold a show & tell to demo what we've built as a result of your contribution. We're also inviting the MoJ design system folks and we've used their Interruption card to also inform this component and pattern. Are there any days / times which work particularly well for you to join a show & tell? Also feel free to invite other folks from your team too! |
Woohoo 🎉 I'll DM you to discuss dates and times 😄 |
At the NHS we’ve just published the Interruption panel variant, to support the Interruption page pattern.
This is based on the longstanding pattern used across GOVUK services (see backlog thread), and the excellent guidance from Ministry of Justice Interruption card component.
This pull request proposes adding the same pattern to the GOV.UK Design System.
Like the NHS one, it uses a variant of the Panel component rather than creating a new component. Unlike the NHS one, as well as setting the background colour to blue, it also sets the text as left-aligned (this is because the default green one is centre-aligned, unlike the NHS version).
Links and buttons currently require
govuk-button--inverseorgovuk-link--inversemodifiers, however these could default to white instead, when used within the panel.