Merge pull request #301 from alphagov/fix_proxy_setting_in_staging

IA-1609: move setting the trust proxy to before middleware init

Author: aaronfowles

src/backend/app.ts

@@ -29,6 +29,12 @@ class App {
   constructor(routes: Routes[]) {
     this.app = express()
     this.port = config.port
+    /*
+    'trust proxy' must be set to 2 when deployed behind GCP load-balancing in order to correctly identify
+    the requestor's IP address rather than that of the load-balancer. This is required for per-user rate-limiting.
+    See also - https://cloud.google.com/load-balancing/docs/https#x-forwarded-for_header
+    */
+    this.app.set('trust proxy', 2)
 
     this.initializeMiddlewares()
     this.initializeRoutes(routes)
@@ -125,12 +131,6 @@ class App {
         genid: generateSessionId,
       })
     )
-    /*
-    'trust proxy' must be set to 2 when deployed behind GCP load-balancing in order to correctly identify
-    the requestor's IP address rather than that of the load-balancer. This is required for per-user rate-limiting.
-    See also - https://cloud.google.com/load-balancing/docs/https#x-forwarded-for_header
-    */
-    this.app.set('trust proxy', 2)
     this.app.use(passport.initialize())
     this.app.use(passport.session())