Merge pull request #5264 from alphagov/audit-ruby

Add Ruby version to applications page

Author: andysellick

app/controllers/govuk_publishing_components/applications_page_controller.rb

@@ -40,6 +40,7 @@ def applications_data(applications)
             gem_version: app.gem_version,
             gem_version_status: app.gem_version == GovukPublishingComponents::VERSION ? "green" : "red",
             sass_version: app.sass_version,
+            ruby_version: app.ruby_version,
           }
         end
       end

app/models/govuk_publishing_components/applications_page.rb

@@ -5,7 +5,8 @@ class ApplicationsPage
     def initialize(application)
       @application = application
       @dir = get_directory
-      @gemfilelock = get_gemfile
+      @gemfilelock = get_file("Gemfile.lock")
+      @rubyfile = get_file(".ruby-version")
     end
 
     def readable_name
@@ -20,27 +21,31 @@ def sass_version
       parse_file(@gemfilelock, /sass-embedded \(([^)>=~ ]+)\)/)
     end
 
+    def ruby_version
+      @rubyfile.strip if @rubyfile
+    end
+
   private
 
     def get_directory
       app_dir = "#{File.expand_path('..')}/#{@application}"
       Dir.exist?(app_dir) ? app_dir : false
     end
 
-    def get_gemfile
-      @dir ? get_gemfile_local : get_gemfile_remote
+    def get_file(name)
+      @dir ? get_local_file(name) : get_remote_file(name)
     end
 
-    def get_gemfile_local
-      lockfile = "#{@dir}/Gemfile.lock"
+    def get_local_file(name)
+      lockfile = "#{@dir}/#{name}"
       return unless File.file?(lockfile)
 
       @source = "local"
       File.read(lockfile)
     end
 
-    def get_gemfile_remote
-      uri = URI("https://raw.githubusercontent.com/alphagov/#{@application}/main/Gemfile.lock")
+    def get_remote_file(name)
+      uri = URI("https://raw.githubusercontent.com/alphagov/#{@application}/main/#{name}")
       result = Net::HTTP.get_response(uri)
       if result.is_a?(Net::HTTPSuccess)
         @source = "remote"

app/views/govuk_publishing_components/applications_page/_table-content.html.erb

@@ -28,5 +28,12 @@
         } %>
       <% end %>
     </td>
+    <td class="govuk-table__cell">
+      <% if app[:ruby_version] %>
+        <%= render "govuk_publishing_components/components/tag", {
+          text: app[:ruby_version],
+        } %>
+      <% end %>
+    </td>
   </tr>
 <% end %>

app/views/govuk_publishing_components/applications_page/show.html.erb

@@ -24,6 +24,7 @@
         <th scope="col" class="govuk-table__header sticky-table-header">Source</th>
         <th scope="col" class="govuk-table__header sticky-table-header">Gem version</th>
         <th scope="col" class="govuk-table__header sticky-table-header">Sass version</th>
+        <th scope="col" class="govuk-table__header sticky-table-header">Ruby version</th>
       </tr>
     </thead>
     <tbody class="govuk-table__body">

spec/component_guide/applications_page_spec.rb

@@ -18,20 +18,28 @@
       govuk_personalisation (>= 0.7.0)
     terser (1.2.6)
       execjs (>= 0.3.0, < 3)"
+  fake_ruby_file = "3.2.1\n"
 
   describe "when the app is found locally" do
     before do
       allow(Dir).to receive(:exist?).and_return(true)
     end
 
-    it "returns all information" do
+    it "can read the gemfile.lock" do
       allow(File).to receive_messages(file?: true, read: fake_gemfile)
       app = GovukPublishingComponents::ApplicationsPage.new(fake_app)
       expect(app.source).to eq("local")
       expect(app.gem_version).to eq("61.3.1")
       expect(app.sass_version).to eq("1.93.2")
     end
 
+    it "can read the ruby version" do
+      allow(File).to receive_messages(file?: true, read: fake_ruby_file)
+      app = GovukPublishingComponents::ApplicationsPage.new(fake_app)
+      expect(app.source).to eq("local")
+      expect(app.ruby_version).to eq("3.2.1")
+    end
+
     it "returns incomplete information" do
       allow(File).to receive_messages(file?: true, read: fake_gemfile_partial)
       app = GovukPublishingComponents::ApplicationsPage.new(fake_app)
@@ -44,20 +52,24 @@
   describe "when the app is not found locally" do
     it "returns no information if the app is not available remotely" do
       stub_request(:get, "https://raw.githubusercontent.com:443/alphagov/#{fake_app}/main/Gemfile.lock").to_return(status: 404, body: "", headers: {})
+      stub_request(:get, "https://raw.githubusercontent.com:443/alphagov/#{fake_app}/main/.ruby-version").to_return(status: 404, body: "", headers: {})
 
       app = GovukPublishingComponents::ApplicationsPage.new(fake_app)
       expect(app.source).to be_nil
       expect(app.gem_version).to be_nil
       expect(app.sass_version).to be_nil
+      expect(app.ruby_version).to be_nil
     end
 
     it "returns all information if the app is available remotely" do
       stub_request(:get, "https://raw.githubusercontent.com:443/alphagov/#{fake_app}/main/Gemfile.lock").to_return(status: 200, body: fake_gemfile, headers: {})
+      stub_request(:get, "https://raw.githubusercontent.com:443/alphagov/#{fake_app}/main/.ruby-version").to_return(status: 200, body: fake_ruby_file, headers: {})
 
       app = GovukPublishingComponents::ApplicationsPage.new(fake_app)
       expect(app.source).to eq("remote")
       expect(app.gem_version).to eq("61.3.1")
       expect(app.sass_version).to eq("1.93.2")
+      expect(app.ruby_version).to eq("3.2.1")
     end
   end
 end