fixup js changes

Author: kr8n3r

tests/pages/pages.py

@@ -318,32 +318,30 @@ def scrollToRevealElement(self, selector=None, xpath=None, stuckToBottom=True):
             var moduleVar = arguments[2];
             var modulePath = arguments[3];
 
-            async function run() {
+            (async function() {
                 try {
                     if (!window.__stickyNavModule) {
                         window.__stickyNavModule = await import(modulePath);
                     }
                     
-                    const handler = window.__stickyNavModule[moduleVar];
-                    let element;
+                    // Re-find the element inside the promise execution 
+                    // so it is as fresh as possible
+                    const element = (type === 'selector') 
+                        ? document.querySelector(locator) 
+                        : document.evaluate(locator, document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue;
                     
-                    if (type === 'selector') {
-                        element = document.querySelector(locator);
-                    } else {
-                        element = document.evaluate(locator, document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue;
-                    }
+                    const handler = window.__stickyNavModule[moduleVar];
                     
                     if (element && handler) {
                         handler.scrollToRevealElement(element);
                         callback(true);
                     } else {
-                        callback(false);
+                        callback('Element not found or handler missing');
                     }
                 } catch (e) {
                     callback('Error: ' + e.message);
                 }
-            }
-            run();
+            })();
         """
 
         # Pass the variables separately. Selenium serializes them correctly.