Merge pull request #950 from alphagov/PP-7211-fix_pact_state_missing_parent_external_id_2

PP-7211 refund needs a real parent id

Author: SandorArpa

src/test/java/uk/gov/pay/ledger/pact/ContractTest.java

@@ -17,6 +17,7 @@
 import uk.gov.pay.ledger.transaction.search.model.RefundSummary;
 import uk.gov.pay.ledger.transaction.state.TransactionState;
 import uk.gov.pay.ledger.util.DatabaseTestHelper;
+import uk.gov.pay.ledger.util.fixture.TransactionFixture;
 
 import java.time.ZonedDateTime;
 import java.util.Map;
@@ -429,7 +430,7 @@ public void createThreePaymentsWithPaidoutDates(Map<String, String> params) {
         String gatewayPayoutId3 = randomAlphanumeric(20);
         String gatewayPayoutId4 = randomAlphanumeric(20);
 
-        aTransactionFixture()
+        TransactionFixture refundParentFixture = aTransactionFixture()
                 .withTransactionType("PAYMENT")
                 .withGatewayAccountId(gatewayAccountId)
                 .withGatewayPayoutId(gatewayPayoutId1)
@@ -446,7 +447,7 @@ public void createThreePaymentsWithPaidoutDates(Map<String, String> params) {
                 .insert(app.getJdbi());
         aTransactionFixture()
                 .withTransactionType("REFUND")
-                .withParentExternalId(randomAlphanumeric(15))
+                .withParentExternalId(refundParentFixture.getExternalId())
                 .withGatewayAccountId(gatewayAccountId)
                 .withGatewayPayoutId(gatewayPayoutId4)
                 .insert(app.getJdbi());