Skip to content

Commit 216523d

Browse files
committed
Fix Rubocop violations triggered by update
1 parent 9cf6b72 commit 216523d

File tree

2 files changed

+15
-15
lines changed

2 files changed

+15
-15
lines changed

app/helpers/tagging_helper.rb

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
module TaggingHelper
22
def tag_summary_rows(type, tagging_update_form_values, linkables, key_text)
3-
case type
4-
when "breadcrumb"
5-
items = breadcrumb(tagging_update_form_values.parent, linkables)
6-
when "browse_pages"
7-
items = browse_pages(tagging_update_form_values.mainstream_browse_pages, linkables)
8-
when "organisations"
9-
items = organisations(tagging_update_form_values.organisations, linkables)
10-
when "related_content"
11-
items = tagging_update_form_values.ordered_related_items
12-
else
13-
[]
14-
end
3+
items = case type
4+
when "breadcrumb"
5+
breadcrumb(tagging_update_form_values.parent, linkables)
6+
when "browse_pages"
7+
browse_pages(tagging_update_form_values.mainstream_browse_pages, linkables)
8+
when "organisations"
9+
organisations(tagging_update_form_values.organisations, linkables)
10+
when "related_content"
11+
tagging_update_form_values.ordered_related_items
12+
else
13+
[]
14+
end
1515

1616
tag_rows(items, key_text)
1717
end
@@ -43,8 +43,8 @@ def tag_rows(items, key_text)
4343
def get_from_mainstream_browse_pages(reference, linkables)
4444
linkables.mainstream_browse_pages.each_value
4545
.flat_map do |level_2|
46-
level_2.select { |page| reference.include? page[1] }
47-
.map { |page| page[0].gsub(" / ", " > ") }
46+
level_2.select { |page| reference.include? page[1] }
47+
.map { |page| page[0].gsub(" / ", " > ") }
4848
end
4949
end
5050
end

app/models/edition.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ def series
162162
end
163163

164164
def history
165-
series.order([version_number: :desc])
165+
series.order([{ version_number: :desc }])
166166
end
167167

168168
def siblings

0 commit comments

Comments
 (0)