label and suffix_label fields seem broken

[kevindew]

As discovered in: #4502

We provide users with an ability to set a label and it doesn't seem to have an affect on the page rendered.

As an example we define one in lib/smart_answer_flows/calculate-your-holiday-entitlement/questions/shift_worker_hours_per_shift.govspeak.erb:

smart-answers/lib/smart_answer_flows/calculate-your-holiday-entitlement/questions/shift_worker_hours_per_shift.govspeak.erb

Lines 5 to 7 in d79d4d1

	<% render_content_for :label do %>
	Hours per shift
	<% end %>

However when we view the page for it there doesn't seem to be any output of it.

I can see suffix labels seem to output:

smart-answers/lib/smart_answer_flows/calculate-your-redundancy-pay/questions/weekly_pay_before_tax.govspeak.erb

Lines 9 to 11 in d79d4d1

	<% render_content_for :suffix_label do %>
	per week
	<% end %>

but I'm not sure that is entirely right based on this example note:

Looks like this might be tied into 95f1463 where a string concatenation process was added that omitted label.

I think to resolve this issue we need to work out whether these inputs provide input. If so where do they go? if not we can delete them.

[theseanything]

The design system has been updated with patterns to handle these labels.

This PR has adopted it for suffix labels - so that should be fixed.

However labels are a mystery - need to do a bit of digging into their original intent. Could they have been an hidden label for accessibility? We only use them for 6 questions out of all the flows and the are:

• Days per week
• Hours per week
• Hours per shift
• Days per pattern
• Shifts per pattern
• Weeks worked at current employer

They sound very suffix-y so could potentially convert them to either a suffix label or question hint text. Then we could just remove the label field all together.