Merge pull request #11012 from alphagov/fix-draft-locale-deletion

[WHIT-2842] Fix draft locale deletion bug in Publishing API

Author: ChrisBAshton

app/services/edition_service.rb

@@ -51,6 +51,10 @@ def notify!
   end
 
   def update_publishing_api!
+    if edition.saved_change_to_primary_locale?
+      Whitehall::PublishingApi.discard_translation_async(edition, locale: edition.primary_locale_before_last_save)
+    end
+
     ServiceListeners::PublishingApiPusher
       .new(edition.reload)
       .push(event: verb, options:)

test/unit/app/services/draft_locale_switch_test.rb

@@ -0,0 +1,44 @@
+require "test_helper"
+
+class DraftLocaleSwitchTest < ActiveSupport::TestCase
+  test "updates Publishing API when changing primary locale of a draft" do
+    edition = create(:draft_document_collection, title: "English Title", primary_locale: "en")
+    edition.primary_locale = "fr"
+    edition.save!
+
+    Whitehall::PublishingApi.expects(:patch_links).at_least_once
+
+    Whitehall::PublishingApi.expects(:save_draft_translation).with(
+      anything,
+      :fr,
+      nil,
+      bulk_publishing: false,
+    )
+
+    Whitehall::PublishingApi.expects(:discard_translation_async).with(
+      anything,
+      locale: "en",
+    )
+
+    DraftEditionUpdater.new(edition, current_user: create(:user)).perform!
+  end
+
+  test "does not discard translation when primary locale is unchanged" do
+    edition = create(:draft_document_collection, title: "English Title", primary_locale: "en")
+    edition.title = "New Title"
+    edition.primary_locale = "en"
+    edition.save!
+
+    Whitehall::PublishingApi.expects(:patch_links).at_least_once
+    Whitehall::PublishingApi.expects(:save_draft_translation).with(
+      anything,
+      :en,
+      nil,
+      bulk_publishing: false,
+    )
+
+    Whitehall::PublishingApi.expects(:discard_translation_async).never
+
+    DraftEditionUpdater.new(edition, current_user: create(:user)).perform!
+  end
+end